fixes #22706; turn "unknown hint" into a hint (#22755)

fixes #22706
nim-lang · Sep 25, 2023 · 3979e83 · 3979e83
1 parent f0bf94e
commit 3979e83
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/compiler/commands.nim b/compiler/commands.nim
@@ -205,7 +205,11 @@ proc processSpecificNote*(arg: string, state: TSpecialWord, pass: TCmdLinePass,
  # unfortunately, hintUser and warningUser clash, otherwise implementation would simplify a bit
  let x = findStr(noteMin, noteMax, id, errUnknown)
  if x != errUnknown: notes = {TNoteKind(x)}
- else: localError(conf, info, "unknown $#: $#" % [name, id])
+ else:
+ if isSomeHint:
+ message(conf, info, hintUnknownHint, id)
+ else:
+ localError(conf, info, "unknown $#: $#" % [name, id])
  case id.normalize
  of "all": # other note groups would be easy to support via additional cases
  notes = if isSomeHint: {hintMin..hintMax} else: {warnMin..warnMax}

diff --git a/compiler/lineinfos.nim b/compiler/lineinfos.nim
@@ -107,6 +107,7 @@ type
  hintUser = "User", hintUserRaw = "UserRaw", hintExtendedContext = "ExtendedContext",
  hintMsgOrigin = "MsgOrigin", # since 1.3.5
  hintDeclaredLoc = "DeclaredLoc", # since 1.5.1
+ hintUnknownHint = "UnknownHint"
 
 const
  MsgKindToStr*: array[TMsgKind, string] = [
@@ -229,6 +230,7 @@ const
  hintExtendedContext: "$1",
  hintMsgOrigin: "$1",
  hintDeclaredLoc: "$1",
+ hintUnknownHint: "unknown hint: $1"
  ]
 
 const