Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hide label option #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

reformatco
Copy link

Allows you to then use the label to generate a class in a template

Allows you to then use the label to generate a class in a template
@nickforddev
Copy link
Owner

@madebyreformat can you provide some more information in this PR about what it accomplishes? Screenshots welcomed.

Also ideally all new features are also added for 4.x version too.

Thanks

@nickforddev nickforddev self-requested a review January 24, 2019 02:32
@reformatco
Copy link
Author

It allows you to toggle showing the label in the admin panel, this is so you can use the label within a theme to specify a class generally as a variable.

I looked at adding a third element to the options array but im not sure its possible after a quick scan of the ACF workings, looks like it's only expecting two items after splitting on the colon

eg. can't add
#ff0000 : class-red : Red

I really like the plugin but don't want to add inline styles within the markup so wanted to toggle classes instead.

I tweaked the CSS for the swatch-toggle if it is selected just to make it a bit bigger too, see below:

screenshot 2019-01-24 at 11 53 25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants