Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: react-native support #2675

Draft
wants to merge 28 commits into
base: main
Choose a base branch
from
Draft

Conversation

onehassan
Copy link
Contributor

No description provided.

@onehassan onehassan self-assigned this Apr 22, 2024
Copy link

changeset-bot bot commented Apr 22, 2024

⚠️ No Changeset found

Latest commit: debe47a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Apr 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
dashboard-staging ✅ Ready (Inspect) Visit Preview May 29, 2024 7:59pm
example-nextjs-server-components ✅ Ready (Inspect) Visit Preview May 29, 2024 7:59pm
example-react-apollo ✅ Ready (Inspect) Visit Preview May 29, 2024 7:59pm
example-sveltekit ✅ Ready (Inspect) Visit Preview May 29, 2024 7:59pm
example-vue-apollo ✅ Ready (Inspect) Visit Preview May 29, 2024 7:59pm
1 Ignored Deployment
Name Status Preview Updated (UTC)
dashboard ⬜️ Ignored (Inspect) Visit Preview May 29, 2024 7:59pm

@onehassan onehassan force-pushed the feat/react-native-support-2 branch from aa606fb to 593fc03 Compare May 20, 2024 10:21
@nhost-build nhost-build added the sdk SDK package label May 20, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.95%. Comparing base (68e0622) to head (debe47a).
Report is 19 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2675      +/-   ##
==========================================
- Coverage   86.06%   85.95%   -0.11%     
==========================================
  Files          86       86              
  Lines        9484     9604     +120     
  Branches      486      485       -1     
==========================================
+ Hits         8162     8255      +93     
- Misses       1322     1349      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

> Make sure you have the [Nhost CLI installed](https://docs.nhost.io/platform/cli).

```sh
cd examples/react_native
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
cd examples/react_native
cd examples/react_native/backend


3. Terminal 1: Start the Nhost Backend

1. Create the `.secrets` file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about github and linkedn? they are in the example .secrets

3. Terminal 1: Start the Nhost Backend

1. Create the `.secrets` file
To be able to start the nhost project locally: you need to a create this file that holds your porject's secrets, follow these guides [Sign In with Apple](https://docs.nhost.io/guides/auth/social/sign-in-apple), [Sign In With Google](https://docs.nhost.io/guides/auth/social/sign-in-google) to setup OAuth and fill the secrets
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe also mention that google/apple can be disabled by editing the nhost.toml. For a quick test you might not want to care about provisioning credentials for those

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or that they can leave the secrets with FIXME and the project will work fine but not the authentication with those two mechanisms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants