Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new action handler for child state #1987

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

maliouris
Copy link

@maliouris maliouris commented Apr 2, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior

When creating an abstract class that has an action handler and this abstract class is inherited by two states they both listen to this action.

What is the new behavior?

  • Add dispatch options in order to scope an action.
  • Now we can use the scope property of the dispatch options and pass a StateClass as a parameter so that only this state handles the corresponding action.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@codeclimate
Copy link

codeclimate bot commented Apr 3, 2023

Code Climate has analyzed commit 6a3a1c9 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 98.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 97.1% (0.0% change).

View more on Code Climate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant