Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
This PR expands the returned types by adding
date
andtime
type formats.What is the current behavior? (You can also link to an open issue here)
If your JSON Schema defines a property like
{ "type": "string", "format": "time" }
, then Formly returns the type "string" only.This means that you don't know if the returned property is supposed to be displayed as a regular input field (current standard behaviour), a time field or a date field.
What is the new behavior (if this is a feature change)?
Formly now additionally returns the types
time
ordate
if the JSON Schema provides properties with the formatstime
ordate
respectively.According to the latest JSON Schema draft an extension of the instance type is possible:
Please check if the PR fulfills these requirements
npm run build
produced a successful build. (Unit testing can be done by runningnpm test
;)npm run lint
to do this.npm run build
will fail if there are files not linted.)Other information:
In case this is classified as a breaking change you could add a flag like "extended instance types" that makes it possible to return
string
,time
anddate
instead of onlystring
?