fix: sonar cloud smells #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportAttention: This version of the Nx Cloud GitHub bot will cease to function on July 1st, 2023. An organization admin can update your integration here. CI is running/has finished running commands for commit 21f3de6. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 7 targets
Sent with 💌 from NxCloud. |
LayZeeDK
reviewed
May 23, 2023
packages/ngworker/lumberjack/src/lib/logging/lumberjack-logger.builder.ts
Outdated
Show resolved
Hide resolved
packages/ngworker/lumberjack/src/lib/logging/lumberjack-log.builder.ts
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed! |
LayZeeDK
approved these changes
May 25, 2023
NachoVazquez
added a commit
that referenced
this pull request
Jun 12, 2023
Please check if your PR fulfills the following requirements: - [x] The commit message follows our guidelines: CONTRIBUTING.md#commit - [ ] Tests for the changes have been added (for bug fixes / features) - [ ] Docs have been added / updated (for bug fixes / features) What kind of change does this PR introduce? <!-- Please check the one that applies to this PR using "x". --> ``` [x] Bugfix [ ] Feature [ ] Code style update (formatting, local variables) [ ] Refactoring (no functional changes, no API changes) [ ] Build related changes [ ] CI related changes [ ] Documentation content changes [ ] Other... Please describe: ``` The Sonar cloud on the main branch reports six smells on the code. The smells are about - replacing || operator with ?? - returning this as the type of fluent API functions - Logical Or operator (||) is replaced for coalescence operator (??) - We set this as the return type of fluent functions ``` [ ] Yes [x] No ``` https://sonarcloud.io/project/issues?resolved=false&id=ngworker_lumberjack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The Sonar cloud on the main branch reports six smells on the code.
The smells are about
What is the new behavior?
Does this PR introduce a breaking change?
Other information
https://sonarcloud.io/project/issues?resolved=false&id=ngworker_lumberjack