Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/139/use provide and with factory functions #144

Merged
merged 45 commits into from
May 23, 2023
Merged

feature/139/use provide and with factory functions #144

merged 45 commits into from
May 23, 2023

Conversation

NachoVazquez
Copy link
Contributor

@NachoVazquez NachoVazquez commented Nov 7, 2022 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines: CONTRIBUTING.md#commit
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Moduleless (standalone) applications have to import Lumberjack modules to make Lumberjack work instead of a more suitable solution like provider factory functions.

Issue Number: #139

What is the new behavior?

Lumberjack can easily be used in standalone applications using the new provider factory functions. These are created for the Lumberjack Core and built-in drivers

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@nx-cloud
Copy link

nx-cloud bot commented Nov 7, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f25c9ec. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 7 targets

Sent with 💌 from NxCloud.

@NachoVazquez NachoVazquez force-pushed the feature/139/use-provide-and-with-factory-functions branch 2 times, most recently from 8d88a66 to aa39f8a Compare November 11, 2022 16:22
@NachoVazquez NachoVazquez marked this pull request as ready for review November 11, 2022 16:40
@LayZeeDK LayZeeDK force-pushed the feature/139/use-provide-and-with-factory-functions branch from 78d0fd5 to 41b3101 Compare November 29, 2022 22:37
LayZeeDK
LayZeeDK requested changes Nov 29, 2022
View reviewed changes
...ker/lumberjack/console-driver/src/lib/configuration/lumberjack-console-driver-root.module.ts Show resolved Hide resolved
...ngworker/lumberjack/console-driver/src/lib/configuration/lumberjack-console-driver.module.ts Outdated Show resolved Hide resolved
...es/ngworker/lumberjack/http-driver/src/lib/configuration/lumberjack-http-driver.providers.ts Outdated Show resolved Hide resolved
...es/ngworker/lumberjack/http-driver/src/lib/configuration/lumberjack-http-driver.providers.ts Outdated Show resolved Hide resolved
packages/ngworker/lumberjack/http-driver/src/lib/configuration/lumberjack-http-driver.module.ts Show resolved Hide resolved
...worker/lumberjack/http-driver/src/lib/configuration/lumberjack-http-driver.providers.spec.ts Outdated Show resolved Hide resolved
...worker/lumberjack/http-driver/src/lib/configuration/lumberjack-http-driver.providers.spec.ts Outdated Show resolved Hide resolved
...es/ngworker/lumberjack/http-driver/src/lib/configuration/lumberjack-http-driver.providers.ts Outdated Show resolved Hide resolved
...es/ngworker/lumberjack/http-driver/src/lib/configuration/lumberjack-http-driver.providers.ts Outdated Show resolved Hide resolved
packages/ngworker/lumberjack/src/lib/logging/lumberjack.service.ts Outdated Show resolved Hide resolved
@LayZeeDK LayZeeDK mentioned this pull request Dec 6, 2022
Merged
3 tasks
@sonarcloud
Copy link

sonarcloud bot commented Dec 11, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@NachoVazquez NachoVazquez force-pushed the feature/139/use-provide-and-with-factory-functions branch from 2a19efe to d58aef5 Compare March 11, 2023 03:18
LayZeeDK
LayZeeDK requested changes Mar 16, 2023
View reviewed changes
packages/ngworker/lumberjack/http-driver/README.md Outdated Show resolved Hide resolved
packages/ngworker/lumberjack/http-driver/README.md Outdated Show resolved Hide resolved
packages/ngworker/lumberjack/http-driver/README.md Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
packages/ngworker/lumberjack/http-driver/README.md Outdated Show resolved Hide resolved
packages/ngworker/lumberjack/http-driver/README.md Outdated Show resolved Hide resolved
packages/ngworker/lumberjack/http-driver/README.md Outdated Show resolved Hide resolved
@NachoVazquez NachoVazquez requested a review from LayZeeDK May 5, 2023 12:05
LayZeeDK
LayZeeDK requested changes May 14, 2023
View reviewed changes
Copy link
Member

@LayZeeDK LayZeeDK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lint and Bug Issues are reported by SonarCloud.

For some reason, lint issues in *.spec.ts files are not reported by SonarCloud, for example this current issue:

http-driver\src\lib\configuration\provide-lumberjack-http-driver.spec.ts
    2:10  warning  'HttpInterceptorFn' is defined but never used  @typescript-eslint/no-unused-vars
  141:45  warning  Unexpected any. Specify a different type       @typescript-eslint/no-explicit-any
  141:56  warning  Unexpected any. Specify a different type       @typescript-eslint/no-explicit-any

@NachoVazquez
Copy link
Contributor Author

Lint and Bug Issues are reported by SonarCloud.

For some reason, lint issues in *.spec.ts files are not reported by SonarCloud, for example this current issue:

http-driver\src\lib\configuration\provide-lumberjack-http-driver.spec.ts
    2:10  warning  'HttpInterceptorFn' is defined but never used  @typescript-eslint/no-unused-vars
  141:45  warning  Unexpected any. Specify a different type       @typescript-eslint/no-explicit-any
  141:56  warning  Unexpected any. Specify a different type       @typescript-eslint/no-explicit-any

Also the ESLint Sonar plugin is not detecting the same stuff as the Cloud

@NachoVazquez
Copy link
Contributor Author

Lint and Bug Issues are reported by SonarCloud.

For some reason, lint issues in *.spec.ts files are not reported by SonarCloud, for example this current issue:

http-driver\src\lib\configuration\provide-lumberjack-http-driver.spec.ts
    2:10  warning  'HttpInterceptorFn' is defined but never used  @typescript-eslint/no-unused-vars
  141:45  warning  Unexpected any. Specify a different type       @typescript-eslint/no-explicit-any
  141:56  warning  Unexpected any. Specify a different type       @typescript-eslint/no-explicit-any

It is working now :)

NachoVazquez and others added 19 commits May 15, 2023 21:06
@NachoVazquez
refactor: replace ts-toolbelt types with homemade one
fbfeeab
@NachoVazquez
fix: allow only enviromental providers
1d44bcd
@NachoVazquez
fix: replace module-full/less languague with classic and standalone
db4d7ce
@NachoVazquez
fix: more moduless language
1a84f63
@NachoVazquez
fix: rename console driver provider
a7d3459
@NachoVazquez
docs: improve the http-driver docs by applying CR suggestions
3249a0e
@NachoVazquez @LayZeeDK
fix: simplify usage of Providers and EnvironmentProviders
73c1b70 
Based on CR suggestions by Lars

Co-authored-by: Lars Gyrup Brink Nielsen <[email protected]>
@NachoVazquez
fix: add missing imports
e632b38
@NachoVazquez
fix: change route to the new provide-console-driver
b28577d
@NachoVazquez
fix: test failing because of wrong path
4b5884d
@NachoVazquez
feat: add api tests for provider functions
d426ea3
@NachoVazquez
feat: create is function helper method
186c6c9
@NachoVazquez
fix: check for it isFunction instead of isClass for export functions
f7e316f
@NachoVazquez
feat: modify provideLumberjackHttpDriver api to support the provideHt…
ce437f6 
…tpClient configurations
@NachoVazquez
feat: add http client features as an argument of the module functions
b9da754
@NachoVazquez
docs: update http driver readme
499f4f6
@NachoVazquez
feat: add tests for the new way of provide http client feature
d34e493
@NachoVazquez
fix: lint issues and configuration
985a4cb
@NachoVazquez
chore: rebase
a220162
@NachoVazquez NachoVazquez force-pushed the feature/139/use-provide-and-with-factory-functions branch from 3f04ea7 to a220162 Compare May 16, 2023 00:08
@sonarcloud
Copy link

sonarcloud bot commented May 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

LayZeeDK
LayZeeDK approved these changes May 22, 2023
View reviewed changes
Copy link
Member

@LayZeeDK LayZeeDK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending answer of 1 question.

.github/workflows/ci.yml Show resolved Hide resolved
@NachoVazquez NachoVazquez merged commit cd72a1b into main May 23, 2023
9 checks passed
@NachoVazquez NachoVazquez deleted the feature/139/use-provide-and-with-factory-functions branch May 23, 2023 06:56
NachoVazquez added a commit that referenced this pull request Jun 12, 2023
@NachoVazquez @LayZeeDK
feature: 139 use provide and with factory functions (#144)
8e11027 
Please check if your PR fulfills the following requirements:

- [x] The commit message follows our guidelines: CONTRIBUTING.md#commit
- [x] Tests for the changes have been added (for bug fixes / features)
- [x] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?

<!-- Please check the one that applies to this PR using "x". -->

```
[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:
```

Moduleless (standalone) applications have to import Lumberjack modules
to make Lumberjack work instead of a more suitable solution like
provider factory functions.

Issue Number: #139

Lumberjack can easily be used in standalone applications using the new
provider factory functions. These are created for the Lumberjack Core
and built-in drivers

```
[ ] Yes
[x] No
```

<!-- If this PR contains a breaking change, please describe the impact
and migration path for existing applications below. -->

---------

Co-authored-by: Lars Gyrup Brink Nielsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LayZeeDK LayZeeDK LayZeeDK approved these changes

@santoshyadavdev santoshyadavdev Awaiting requested review from santoshyadavdev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@NachoVazquez @LayZeeDK @santoshyadavdev