fix: sonar cloud smells

ngworker · May 23, 2023 · d612313 · d612313
1 parent cd72a1b
commit d612313
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 6 deletions.
diff --git a/packages/internal/console-driver/test-util/src/lib/noop-console/noop-console.module.ts b/packages/internal/console-driver/test-util/src/lib/noop-console/noop-console.module.ts
@@ -10,7 +10,7 @@ import { NoopConsole } from './noop-console.service';
  deps: [[new Optional(), new SkipSelf(), NoopConsole]],
  provide: lumberjackConsoleToken,
  useFactory: (maybeExistingInstance: NoopConsole | null): NoopConsole =>
- maybeExistingInstance || new NoopConsole(),
+ maybeExistingInstance ?? new NoopConsole(),
  },
  ],
 })

diff --git a/packages/internal/console-driver/test-util/src/lib/spy-console/spy-console.module.ts b/packages/internal/console-driver/test-util/src/lib/spy-console/spy-console.module.ts
@@ -9,7 +9,7 @@ import { SpyConsole } from './spy-console.service';
  {
  deps: [[new Optional(), new SkipSelf(), SpyConsole]],
  provide: lumberjackConsoleToken,
- useFactory: (maybeExistingInstance: SpyConsole | null): SpyConsole => maybeExistingInstance || new SpyConsole(),
+ useFactory: (maybeExistingInstance: SpyConsole | null): SpyConsole => maybeExistingInstance ?? new SpyConsole(),
  },
  ],
 })

diff --git a/packages/internal/test-util/src/lib/object-driver/object.service.ts b/packages/internal/test-util/src/lib/object-driver/object.service.ts
@@ -5,6 +5,6 @@ import { ObjectPayload } from './object.payload';
 @Injectable({ providedIn: 'root' })
 export class ObjectService {
  log(object?: ObjectPayload): boolean {
- return object?.isWorking || false;
+ return object?.isWorking ?? false;
  }
 }
diff --git a/packages/ngworker/lumberjack/src/lib/logging/lumberjack-log.builder.ts b/packages/ngworker/lumberjack/src/lib/logging/lumberjack-log.builder.ts
@@ -44,7 +44,7 @@ export class LumberjackLogBuilder<TPayload extends LumberjackLogPayload | void =
  message: this.message,
  scope: this.scope,
  createdAt: this.time.getUnixEpochTicks(),
- payload: (payloadArg[0] || this.payload) as Exclude<TPayload, InternalWithStaticPayload>,
+ payload: (payloadArg[0] ?? this.payload) as Exclude<TPayload, InternalWithStaticPayload>,
  };
  }
 
@@ -62,7 +62,7 @@ export class LumberjackLogBuilder<TPayload extends LumberjackLogPayload | void =
  /**
  * Add a scope to the log.
  */
- withScope(scope: string): LumberjackLogBuilder<TPayload> {
+ withScope(scope: string): this {
  this.scope = scope;
 
  return this;

diff --git a/packages/ngworker/lumberjack/src/lib/logging/lumberjack-logger.builder.ts b/packages/ngworker/lumberjack/src/lib/logging/lumberjack-logger.builder.ts
@@ -30,7 +30,7 @@ export class LumberjackLoggerBuilder<TPayload extends LumberjackLogPayload | voi
  /**
  * Add a scope to the `LumberjackLog`
  */
- withScope(scope: string): LumberjackLoggerBuilder<TPayload> {
+ withScope(scope: string): this {
  this.scope = scope;
 
  return this;