Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: club cards fade in #1227

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: club cards fade in #1227

wants to merge 3 commits into from

Conversation

r0ld3x
Copy link

@r0ld3x r0ld3x commented Feb 26, 2024

fix: club cards fade in

closes #1211

👷🏻 Changes made

Added a left and right box shdow with border raduis so that it can look more sylish. Although little work is needed on this pr itself

📸 Screenshots

image

@github-actions github-actions bot added status: todo ⏳ This issue is yet to be seen by the maintainer of the project. 🐞 bug This is a patch, generally fixing some bugs. labels Feb 26, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @r0ld3x, thank you for raising a pull request.

Currently, the pull request is marked as https://github.com/MilanCommunity/Milan/labels/status%3A%20todo%20%E2%8F%B3 so please wait until the maintainers/owner review it and provide you with feedback/suggestions to proceed further.

Feel free to reach out to Tamal on Twitter, or drop a mail at [email protected] if you think that this pull request is of critical priority.

Give us a ⭐ to show some support
Happy OpenSource 🚀

@tamalCodes
Copy link
Member

Instead of the fading in effect looking dark can we make it whitish so that it matches with the theme of the website ? That'd be great I guess.

image

@tamalCodes tamalCodes added status: need changes 🚧 Changes have been requested for these PRs and removed status: todo ⏳ This issue is yet to be seen by the maintainer of the project. labels Feb 27, 2024
@r0ld3x
Copy link
Author

r0ld3x commented Feb 28, 2024

Instead of the fading in effect looking dark can we make it whitish so that it matches with the theme of the website ? That'd be great I guess.

image

Ok I'll do

@r0ld3x
Copy link
Author

r0ld3x commented Feb 29, 2024

@tamalCodes check again. :)

@r0ld3x
Copy link
Author

r0ld3x commented Feb 29, 2024

White is not working maybe because of the white background itself

@r0ld3x
Copy link
Author

r0ld3x commented Mar 2, 2024

@tamalCodes

@tamalCodes
Copy link
Member

I see,

Have you seen our Navbar ? We have a blurry background to it, instead of plain white. In this case can we use something similar to it ?

@r0ld3x
Copy link
Author

r0ld3x commented Mar 3, 2024

I see,

Have you seen our Navbar ? We have a blurry background to it, instead of plain white. In this case can we use something similar to it ?

So should I add a blurry background behind that?

@r0ld3x
Copy link
Author

r0ld3x commented Mar 3, 2024

image This with red border or

image with box shadow

or this red borer with little greyish background
image

@tamalCodes
Copy link
Member

I think it'll be better if we leave it at white.

Copy link

This pull request has been deployed to Vercel.

Latest commit: c6b1675
✅ Preview: https://milan-4v59svx56-iamtamal.vercel.app
🔍 Inspect: https://vercel.com/iamtamal/milan/AbcZTwhS2PaSbDRRxqaNqJiS7Nq7

View Workflow Logs

@r0ld3x
Copy link
Author

r0ld3x commented Mar 11, 2024

I think it'll be better if we leave it at white.

wdym?

ok so just add border-radius

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug This is a patch, generally fixing some bugs. status: need changes 🚧 Changes have been requested for these PRs
Projects
Status: In Progress (PRs)
Development

Successfully merging this pull request may close these issues.

Bug: Club cards fade in
2 participants