Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Use .env file for Port, Network Expose and remove React Scripts #1230

Open
3 of 5 tasks
developerTested opened this issue Mar 1, 2024 · 4 comments · May be fixed by #1234
Open
3 of 5 tasks

Feature: Use .env file for Port, Network Expose and remove React Scripts #1230

developerTested opened this issue Mar 1, 2024 · 4 comments · May be fixed by #1234
Assignees
Labels
area/dx This issue is related to improvment of Developer Experience 💡 feature This generally contains addition/changes to features. status: wip 👩🏻‍💻 This issue/PR is actively being worked on.

Comments

@developerTested
Copy link

Description

Currently package.json contain React-Scripts which is not being used in my view.

Vite development Port is set in package.json and Vite.config.js which is HardCoded so it should be .env file based so if repo update user changes regrading PORT and NETWORK expose shouldn't be override by updates.

Proposed Solution

  1. Remove port from package.json and vite config
  2. Remove React-Scripts

Screenshots

No response

🥦 Browser

Mozilla Firefox

Checklist ✅

  • I checked and didn't find similar issue
  • I have read the Contributing Guidelines
  • I am participating in JWOC
  • I am participating in IWOC
  • I am willing to work on this issue (blank for no)
@developerTested developerTested added status: todo ⏳ This issue is yet to be seen by the maintainer of the project. 💡 feature This generally contains addition/changes to features. labels Mar 1, 2024
Copy link

github-actions bot commented Mar 1, 2024

Hello @developerTested, thank you for raising the issue.

Currently, the issue is marked as https://github.com/MilanCommunity/Milan/labels/status%3A%20todo%20%E2%8F%B3 so please wait until the maintainers/owner review it and provide you with feedback/suggestions to proceed further.

Feel free to reach out to Tamal on Twitter, or drop a mail at [email protected] if you think that this issue is of critical priority.

Give us a ⭐ to show some support
Happy OpenSource 🚀

@r0ld3x
Copy link

r0ld3x commented Mar 2, 2024

I think vite --port 3000 solves this problem

@developerTested
Copy link
Author

I think vite --port 3000 solves this problem

You're but that is issue because that is hardcoded in package.json which can be overridden when thee is an update in package.json so to bypass that u need to store it somewhere user have control over it.

Check repo package.json and vite.config.js there its Hardcoded.

if we use .env file no user change will be overridden which is main aim of this issue

@tamalCodes
Copy link
Member

Hey @developerTested , this is a good DX - please start working on the same.

Also yes, I guess we never removed the unused dependencies - while you are at it, do remove the unused ones. Add documentation and update .env.example for the same.

📑 Checklist in case you missed something

Please maintain structure, use conventional pull request titles, and avoid spam to avoid closure or bans.

@tamalCodes tamalCodes added area/dx This issue is related to improvment of Developer Experience status: wip 👩🏻‍💻 This issue/PR is actively being worked on. and removed status: todo ⏳ This issue is yet to be seen by the maintainer of the project. labels Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dx This issue is related to improvment of Developer Experience 💡 feature This generally contains addition/changes to features. status: wip 👩🏻‍💻 This issue/PR is actively being worked on.
Projects
Status: In Progress (Issues)
Development

Successfully merging a pull request may close this issue.

3 participants