Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Club cards fade in #1211

Open
3 of 5 tasks
tamalCodes opened this issue Feb 6, 2024 · 6 comments · May be fixed by #1227
Open
3 of 5 tasks

Bug: Club cards fade in #1211

tamalCodes opened this issue Feb 6, 2024 · 6 comments · May be fixed by #1227
Assignees
@Anushkabh
Labels
🐞 bug This is a patch, generally fixing some bugs. JWOC medium status: wip 👩🏻‍💻 This issue/PR is actively being worked on.

Comments

@tamalCodes
Copy link
Member

Description

Currently, the cuts are looking very sharp We might need to add some hazy effect so that it looks like they are fading in gradually rather than total separable cuts- this can be done with CSS.

Checkout the fade in a style that I have attached in one of the screenshot.

Proposed Solution

Different styles can be implemented for a fade away effect.

Screenshots

image

image

Browser 🥦

Google Chrome

Checklist ✅

  • I checked and didn't find similar issue
  • I have read the Contributing Guidelines
  • I am participating in JWOC
  • I am participating in IWOC
  • I am willing to work on this issue (blank for no).
@tamalCodes tamalCodes added 🐞 bug This is a patch, generally fixing some bugs. status: todo ⏳ This issue is yet to be seen by the maintainer of the project. JWOC medium labels Feb 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2024

Hello @tamalCodes, thank you for raising the issue.

Currently, the issue is marked as https://github.com/MilanCommunity/Milan/labels/status%3A%20todo%20%E2%8F%B3 so please wait until the maintainers/owner review it and provide you with feedback/suggestions to proceed further.

Feel free to reach out to Tamal on Twitter, or drop a mail at [email protected] if you think that this issue is of critical priority.

Give us a ⭐ to show some support
Happy OpenSource 🚀

@Anushkabh
Copy link

i would like to work under JWOC .. kindly assign @tamalCodes

@tamalCodes
Copy link
Member Author

Yeah sure go ahead @Anushkabh

@tamalCodes tamalCodes added status: wip 👩🏻‍💻 This issue/PR is actively being worked on. and removed status: todo ⏳ This issue is yet to be seen by the maintainer of the project. labels Feb 16, 2024
@r0ld3x
Copy link

r0ld3x commented Feb 25, 2024 •
edited

2024-02-25.12-59-32.mp4

I added

border-radius: 30px;
box-shadow: 
  inset -10px 0 10px -10px rgba(0, 0, 0, 0.5),
  inset 10px 0 10px -10px rgba(0, 0, 0, 0.5);

on src/components/private/landing/Landing.scss

I dont know how to index that shadow to the top
I tried different ways but still could not found any solution.

@tamalCodes
Copy link
Member Author

These all might need fixes , do make a PR, I'll take a look at the code and run it locally
image

@r0ld3x
Copy link

r0ld3x commented Feb 25, 2024

These all might need fixes , do make a PR, I'll take a look at the code and run it locally
image

Ok

@r0ld3x r0ld3x linked a pull request Feb 26, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Anushkabh Anushkabh

Labels
🐞 bug This is a patch, generally fixing some bugs. JWOC medium status: wip 👩🏻‍💻 This issue/PR is actively being worked on.
Projects
Milan
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: club cards fade in r0ld3x/Milan
3 participants
@tamalCodes @r0ld3x @Anushkabh