Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

demo(tooltip): rephrased comments in tooltip #4693

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

demo(tooltip): rephrased comments in tooltip #4693

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/tooltip/tooltip.ts
View file
Open in desktop
Expand Up @@ -325,7 +325,7 @@ export class NgbTooltip implements OnInit, OnDestroy, OnChanges {

ngOnDestroy() {
this.close(false);
// This check is needed as it might happen that ngOnDestroy is called before ngOnInit
// This check is necessary because it's possible that ngOnDestroy could be invoked before ngOnInit.
// under certain conditions, see: https://github.com/ng-bootstrap/ng-bootstrap/issues/2199
this._unregisterListenersFn?.();
}
Expand Down