fix(select): onSelectionChange can handle number #2937
Conversation
🦋 Changeset detectedLatest commit: be805e4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughThe recent updates across multiple components and files primarily involve changing the structure of items from using a Changes
Assessment against linked issues
Possibly related issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ryo-manba
changed the title
| <SelectItem key={animal.value} value={animal.value}> | ||
| <SelectItem key={animal.key}> |
There was a problem hiding this comment.
There is no need to give value to SelectItem, so it is removed.
See: https://nextui.org/docs/components/select#selectitem-props
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Out of diff range and nitpick comments (4)
apps/docs/content/docs/components/select.mdx (4)
73-73: Ensure the highlighted lines property is correctly set for the "Disabled Items" code demo.It's good practice to ensure that the
highlightedLinesproperty accurately reflects the lines of code that are relevant to the demonstration, especially when changes are made to the examples.
84-84: Verify the highlighted lines for the "Sizes" code demo.Similar to the previous comment, please check that the
highlightedLinesproperty in the "Sizes" code demo correctly highlights the relevant lines. This helps users quickly identify the important parts of the code example.
102-102: Check the highlighted lines for accuracy in the "Label Placements" code demo.As with other code demos, ensuring that the
highlightedLinesproperty accurately reflects the important lines in the "Label Placements" code demo enhances the documentation's usability.
111-111: Confirm the highlighted lines setting in the "Start Content" code demo.Ensuring that the
highlightedLinesproperty is correctly set in the "Start Content" code demo will help users understand which parts of the code are most relevant to the example being demonstrated.
Review Details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (26)
- .changeset/green-ravens-brake.md (1 hunks)
- apps/docs/content/components/select/colors.ts (2 hunks)
- apps/docs/content/components/select/custom-selector-icon.ts (2 hunks)
- apps/docs/content/components/select/description.ts (2 hunks)
- apps/docs/content/components/select/disabled-items.ts (2 hunks)
- apps/docs/content/components/select/disabled.ts (2 hunks)
- apps/docs/content/components/select/dynamic.ts (2 hunks)
- apps/docs/content/components/select/error-message.ts (2 hunks)
- apps/docs/content/components/select/label-placements.ts (3 hunks)
- apps/docs/content/components/select/multiple-controlled-onchange.ts (3 hunks)
- apps/docs/content/components/select/multiple-controlled.ts (3 hunks)
- apps/docs/content/components/select/multiple.ts (2 hunks)
- apps/docs/content/components/select/open-state.ts (2 hunks)
- apps/docs/content/components/select/radius.ts (2 hunks)
- apps/docs/content/components/select/required.ts (2 hunks)
- apps/docs/content/components/select/single-controlled-onchange.ts (3 hunks)
- apps/docs/content/components/select/single-controlled.ts (3 hunks)
- apps/docs/content/components/select/sizes.ts (3 hunks)
- apps/docs/content/components/select/start-content.ts (2 hunks)
- apps/docs/content/components/select/usage.ts (3 hunks)
- apps/docs/content/components/select/variants.ts (3 hunks)
- apps/docs/content/components/select/without-scroll-shadow.ts (2 hunks)
- apps/docs/content/docs/components/select.mdx (4 hunks)
- packages/components/select/tests/select.test.tsx (15 hunks)
- packages/components/select/src/select.tsx (1 hunks)
- packages/hooks/use-aria-multiselect/src/use-multiselect-list-state.ts (2 hunks)
Files skipped from review due to trivial changes (1)
- packages/hooks/use-aria-multiselect/src/use-multiselect-list-state.ts
Additional Context Used
LanguageTool (379)
.changeset/green-ravens-brake.md (1)
Near line 6: Possible spelling mistake found.
Context: ...g/use-aria-multiselect": patch --- Fix onSelectionChange can handle number (#2926)apps/docs/content/docs/components/select.mdx (378)
Near line 5: This sentence does not start with an uppercase letter.
Context: ...er to select one or more of them." --- import {selectContent} from "@/content/compone...
Near line 9: The plural noun “displays” cannot be used with the article “A”. Did you mean “A select display” or “select displays”?
Context: .../content/components/select"; # Select A select displays a collapsible list of options and allow...
Near line 20: Possible spelling mistake found.
Context: ...> --- ## Installation <PackageManagers showGlobalInstallWarning commands={...
Near line 21: Possible spelling mistake found.
Context: .../> ## Installation <PackageManagers showGlobalInstallWarning commands={{ cli: "nextui add sele...
Near line 22: Don’t put a space after the opening parenthesis.
Context: ... showGlobalInstallWarning commands={{ cli: "nextui add select", npm: "...
Near line 23: Possible spelling mistake found.
Context: ...wGlobalInstallWarning commands={{ cli: "nextui add select", npm: "npm ins...
Near line 23: Possible spelling mistake found.
Context: ...lInstallWarning commands={{ cli: "nextui add select", npm: "npm install @nex...
Near line 24: Possible spelling mistake found.
Context: ...ds={{ cli: "nextui add select", npm: "npm install @nextui-org/select", ...
Near line 24: Possible spelling mistake found.
Context: ... cli: "nextui add select", npm: "npm install @nextui-org/select", yarn: ...
Near line 26: Possible spelling mistake found.
Context: ...arn: "yarn add @nextui-org/select", pnpm: "pnpm add @nextui-org/select", bun...
Near line 26: Possible spelling mistake found.
Context: ...arn add @nextui-org/select", pnpm: "pnpm add @nextui-org/select", bun: "bun ...
Near line 28: Don’t put a space before the closing parenthesis.
Context: ... bun: "bun add @nextui-org/select" }} /> ## Import NextUI exports 3 select...
Near line 32: Possible spelling mistake found.
Context: ...@nextui-org/select" }} /> ## Import NextUI exports 3 select-related components: -...
Near line 36: Possible spelling mistake found.
Context: ...a wrapper for the other components. - SelectSection: The component that contains a group ...
Near line 37: Possible spelling mistake found.
Context: ...t contains a group of select items. - SelectItem: The component that represents a sele...
Near line 39: Possible spelling mistake found.
Context: ...ponent that represents a select item. <ImportTabs commands={{ main: 'import {Select...
Near line 40: Don’t put a space after the opening parenthesis.
Context: ...a select item. <ImportTabs commands={{ main: 'import {Select, SelectSection...
Near line 41: Possible spelling mistake found.
Context: ... commands={{ main: 'import {Select, SelectSection, SelectItem} from "@nextui-org/react";'...
Near line 41: Possible spelling mistake found.
Context: ... main: 'import {Select, SelectSection, SelectItem} from "@nextui-org/react";', indivi...
Near line 42: Possible spelling mistake found.
Context: ...ct";', individual: 'import {Select, SelectSection, SelectItem} from "@nextui-org/select";...
Near line 42: Possible spelling mistake found.
Context: ...vidual: 'import {Select, SelectSection, SelectItem} from "@nextui-org/select";', }} /> ...
Near line 43: Don’t put a space before the closing parenthesis.
Context: ...lectItem} from "@nextui-org/select";', }} /> ## Usage <CodeDemo title="Usage" ...
Near line 61: Possible spelling mistake found.
Context: ...### Multiple Selection You can use theselectionMode="multiple"property to allow multiple ...
Near line 71: Possible spelling mistake found.
Context: ...can disable specific items by using thedisabledKeysproperty. <CodeDemo title="Disabled I...
Near line 77: Possible spelling mistake found.
Context: ...tems} /> ### Required If you pass theisRequiredproperty to the select, it will have a...
Near line 100: Possible spelling mistake found.
Context: ...he position of the label by setting thelabelPlacementproperty toinside,outsideor `ou...
Near line 104: Possible spelling mistake found.
Context: ...te**: If thelabelis not passed, thelabelPlacementproperty will beoutsideby default....
Near line 108: Possible spelling mistake found.
Context: ...lt. ### Start Content You can use thestartContentandendContentproperties to add con...
Near line 108: Possible spelling mistake found.
Context: ...ent You can use thestartContentandendContentproperties to add content to the start...
Near line 115: Possible spelling mistake found.
Context: ... Since theSelectcomponent uses the Listbox component un...
Near line 116: Possible spelling mistake found.
Context: ...mponent under the hood, you can use thestartContentandendContentproperties of the `Se...
Near line 116: Possible spelling mistake found.
Context: ...ood, you can use thestartContentandendContentproperties of theSelectItemcompone...
Near line 116: Possible spelling mistake found.
Context: ...entandendContentproperties of theSelectItem` component to add content to the start ...
Near line 122: Did you mean: “By default,”?
Context: ...tContent} /> ### Custom Selector Icon By default the select uses achevron-downicon a...
Near line 124: Possible spelling mistake found.
Context: ...his icon by passing a custom one to theselectorIconproperty. <CodeDemo title="Custom Sel...
Near line 128: Possible spelling mistake found.
Context: ...omSelectorIcon} /> > Note: Use thedisableSelectorIconRotationproperty to disable the rotation of th...
Near line 132: Possible spelling mistake found.
Context: ...roll Shadow Select component uses the ScrollShadow under ...
Near line 133: Possible spelling mistake found.
Context: ...isable this shadow by passing using thescrollShadowPropsproperty. <CodeDemo title="Without Sc...
Near line 137: Possible spelling mistake found.
Context: ...w} /> > Note: You can also use theshowScrollIndicatorsproperty to disable the scroll indicat...
Near line 147: Possible spelling mistake found.
Context: ...With Error Message You can combine theisInvalidanderrorMessageproperties to show ...
Near line 147: Possible spelling mistake found.
Context: ...ge You can combine theisInvalidanderrorMessageproperties to show an invalid select. ...
Near line 153: Possible spelling mistake found.
Context: ...ge} /> ### Controlled You can use theselectedKeysandonSelectionChange/onChangep...
Near line 153: Possible spelling mistake found.
Context: ...led You can use theselectedKeysandonSelectionChange/onChangeproperties to control the...
Near line 153: Possible spelling mistake found.
Context: ...selectedKeysandonSelectionChange/onChange` properties to control the select value...
Near line 155: Possible spelling mistake found.
Context: ...ies to control the select value. UsingonSelectionChange: <CodeDemo title="Controlled with onS...
Near line 159: Possible spelling mistake found.
Context: ...lectContent.singleControlled} /> UsingonChange: <CodeDemo title="Controlled with onC...
Near line 165: Possible spelling mistake found.
Context: ...e open state of the select by using theisOpenandonOpenChange/onClosepropert...
Near line 165: Possible spelling mistake found.
Context: ...of the select by using theisOpenandonOpenChange/onCloseproperties. <CodeDemo tit...
Near line 165: Possible spelling mistake found.
Context: ...using theisOpenandonOpenChange/onCloseproperties. <CodeDemo title="Controll...
Near line 171: Possible spelling mistake found.
Context: ...omize the select items by modifying theSelectItemchildren. <CodeDemo title="Custom Ite...
Near line 176: Did you mean: “By default,”?
Context: ...stomItems} /> ### Custom Render Value By default the select will render the selected ite...
Near line 177: Possible spelling mistake found.
Context: ...but you can customize this by passing arenderValuefunction. <CodeDemo title="Custom Ren...
Near line 181: Possible spelling mistake found.
Context: ...electContent.customRenderValue} /> TherenderValuefunction receives the selected items a...
Near line 181: Possible spelling mistake found.
Context: ... items as a parameter and must return aReactNode. Check the [Render Value Function](#re...
Near line 186: The name of this game or TV show is spelled with an accent.
Context: ...e are using a custom hook to fetch the Pokemon API...
Near line 186: Possible spelling mistake found.
Context: ...2/pokemon) data in combination with theuseInfiniteScrollhook to load more data when the user r...
Near line 188: Possible spelling mistake found.
Context: ... user reaches the end of the list. TheisLoadingprop is used to show a loading indicat...
Near line 190: Possible spelling mistake found.
Context: ... icon when the data is being fetched. <PackageManagers showGlobalInstallWarning commands={...
Near line 191: Possible spelling mistake found.
Context: ...a is being fetched. <PackageManagers showGlobalInstallWarning commands={{ npm: "npm install @ne...
Near line 192: Don’t put a space after the opening parenthesis.
Context: ... showGlobalInstallWarning commands={{ npm: "npm install @nextui-org/use-in...
Near line 193: Possible spelling mistake found.
Context: ...wGlobalInstallWarning commands={{ npm: "npm install @nextui-org/use-infinite-...
Near line 193: Possible spelling mistake found.
Context: ...lInstallWarning commands={{ npm: "npm install @nextui-org/use-infinite-scroll...
Near line 195: Possible spelling mistake found.
Context: ...d @nextui-org/use-infinite-scroll", pnpm: "pnpm add @nextui-org/use-infinite-scr...
Near line 195: Possible spelling mistake found.
Context: ...ui-org/use-infinite-scroll", pnpm: "pnpm add @nextui-org/use-infinite-scroll", ...
Near line 196: Don’t put a space before the closing parenthesis.
Context: ... add @nextui-org/use-infinite-scroll", }} /> ```jsx import {useInfiniteScroll} ...
Near line 219: Possible spelling mistake found.
Context: ... /> ### With Sections You can use theSelectSectioncomponent to group select items. <Cod...
Near line 225: Possible spelling mistake found.
Context: ...stomize the sections style by using theclassNamesproperty of theSelectSectioncompon...
Near line 225: Possible spelling mistake found.
Context: ... using theclassNamesproperty of theSelectSectioncomponent. <CodeDemo title="Custom Se...
Near line 231: Possible spelling mistake found.
Context: ... select to control the multiple select,selectedKeysandonSelectionChange/onChange. ...
Near line 231: Possible spelling mistake found.
Context: ...the multiple select,selectedKeysandonSelectionChange/onChange. Using `onSelectionChang...
Near line 231: Possible spelling mistake found.
Context: ...selectedKeysandonSelectionChange/onChange. UsingonSelectionChange`: <CodeDem...
Near line 233: Possible spelling mistake found.
Context: ...onSelectionChange/onChange. UsingonSelectionChange`: <CodeDemo title="Multiple Selectio...
Near line 240: Possible spelling mistake found.
Context: ...ctContent.multipleControlled} /> UsingonChange: <CodeDemo title="Multiple Selectio...
Near line 249: Possible spelling mistake found.
Context: ...ponent as the select value by using therenderValueproperty. In this example we are using...
Near line 249: It appears that a comma is missing.
Context: ...ing therenderValueproperty. In this example we are using the [Chip](/docs/component...
Near line 254: Possible spelling mistake found.
Context: ...} /> > Note: Make sure to pass theisMultilineproperty to theSelectcomponent to ...
Near line 256: Possible spelling mistake found.
Context: ...ponent to allow the chips to wrap. TherenderValuefunction receives the selected items a...
Near line 256: Possible spelling mistake found.
Context: ... items as a parameter and must return aReactNode. Check the [Render Value Function](#re...
Near line 261: Possible spelling mistake found.
Context: ...ize any slot of the select by using theclassNamesproperty. Select component also provid...
Near line 262: Possible spelling mistake found.
Context: ...ty. Select component also provides the popoverProps and [lis...
Near line 262: Possible spelling mistake found.
Context: ...ops](/docs/components/popover#api) and listboxProps properti...
Near line 263: Possible spelling mistake found.
Context: ...properties to customize the popover and listbox components. <CodeDemo title="Custom St...
Near line 269: This sentence does not start with an uppercase letter.
Context: ...Content.customStyles} /> ## Slots - base: The main wrapper of the select. This...
Near line 270: This sentence does not start with an uppercase letter.
Context: .... This wraps the rest of the slots. - label: The label of the select. - **mainWra...
Near line 271: Possible spelling mistake found.
Context: ...label: The label of the select. - mainWrapper: Wraps thehelperWrapperand the `t...
Near line 271: Possible spelling mistake found.
Context: ...he select. - mainWrapper: Wraps thehelperWrapperand thetriggerslots. - trigger...
Near line 272: This sentence does not start with an uppercase letter.
Context: ...erWrapperand thetrigger` slots. - trigger: The trigger of the select. This wrap...
Near line 272: Possible missing comma found.
Context: ...e trigger of the select. This wraps the label the inner wrapper and the selector icon...
Near line 272: Possible missing preposition found.
Context: ...ger of the select. This wraps the label the inner wrapper and the selector icon. - ...
Near line 273: Possible spelling mistake found.
Context: ...nner wrapper and the selector icon. - innerWrapper: The wrapper of the select content. T...
Near line 274: Possible spelling mistake found.
Context: ...t/end content and the select value. - selectorIcon: The selector icon of the select. Thi...
Near line 275: This sentence does not start with an uppercase letter.
Context: ...n the select is open (data-open). - value: The select value. This is also the s...
Near line 275: Possible spelling mistake found.
Context: ...e. This is also the slot that wraps therenderValuefunction result. - listboxWrapper:...
Near line 276: Possible spelling mistake found.
Context: ... therenderValuefunction result. - listboxWrapper: The wrapper of the listbox. This wra...
Near line 276: Possible spelling mistake found.
Context: ... listboxWrapper: The wrapper of the listbox. This wraps the listbox component, this...
Near line 276: Possible spelling mistake found.
Context: ... wrapper of the listbox. This wraps the listbox component, this slot is used on top of ...
Near line 277: This sentence does not start with an uppercase letter.
Context: ...top of the scroll shadow component. - listbox: The listbox component. This is the c...
Near line 277: Possible spelling mistake found.
Context: ...ll shadow component. - listbox: The listbox component. This is the component that w...
Near line 278: Possible spelling mistake found.
Context: ...ponent that wraps the select items. - popoverContent: The popover content slot. Use this t...
Near line 279: Possible spelling mistake found.
Context: ... modify the popover content styles. - helperWrapper: The wrapper of the helper text. This...
Near line 280: This sentence does not start with an uppercase letter.
Context: ... helper text and the error message. - description: The description of the select. - **e...
Near line 281: Possible spelling mistake found.
Context: ...n**: The description of the select. - errorMessage: The error message of the select. ##...
Near line 287: This sentence does not start with an uppercase letter.
Context: ... attributes on thebaseelement: - data-filled: Indicates if the select has a valu...
Near line 290: This sentence does not start with an uppercase letter.
Context: ...start/end content or is open.Selecthas the following attributes on the `trigge...
Near line 292: This sentence does not start with an uppercase letter.
Context: ...tributes on thetriggerelement: - data-open: Indicates if the select is open. -...
Near line 294: This sentence does not start with an uppercase letter.
Context: ... Indicates if the select is open. - data-disabled: When the select trigger is disable...
Near line 295: Possible spelling mistake found.
Context: ...ct trigger is disabled. Based on selectisDisabledprop. - data-focus: When the sel...
Near line 296: This sentence does not start with an uppercase letter.
Context: ... Based on selectisDisabledprop. - data-focus: When the select trigger is being f...
Near line 297: Possible spelling mistake found.
Context: ...ect trigger is being focused. Based on [useFocusRing](https://react-spectrum.adobe.com/react...
Near line 298: This sentence does not start with an uppercase letter.
Context: ....com/react-aria/useFocusRing.html). - data-focus-visible: When the select trigger is being f...
Near line 299: Possible spelling mistake found.
Context: ...ng focused with the keyboard. Based on [useFocusRing](https://react-spectrum.adobe.com/react...
Near line 300: This sentence does not start with an uppercase letter.
Context: ....com/react-aria/useFocusRing.html). - data-pressed: When the select trigger is pressed...
Near line 301: Unpaired symbol: ‘]’ seems to be missing
Context: ...the select trigger is pressed. Based on [usePress](https://react-spectrum.adobe.c...
Near line 301: Possible spelling mistake found.
Context: ...he select trigger is pressed. Based on [usePress](https://react-spectrum.adobe.com/react...
Near line 303: Unpaired symbol: ‘]’ seems to be missing
Context: ...lect trigger is being hovered. Based on [useHover](https://react-spectrum.adobe.c...
Near line 303: Possible spelling mistake found.
Context: ...ect trigger is being hovered. Based on [useHover](https://react-spectrum.adobe.com/react...
Near line 305: Possible spelling mistake found.
Context: ...cthas the following attributes on theselectorIcon` element: - data-open: Indicates...
Near line 307: This sentence does not start with an uppercase letter.
Context: ...tes on theselectorIconelement: - data-open: Indicates if the select is open. ...
Near line 310: This sentence does not start with an uppercase letter.
Context: ...es if the select is open.SelectItemhas the following attributes on thebase...
Near line 312: This sentence does not start with an uppercase letter.
Context: ... attributes on thebaseelement: - data-disabled: When the select item is disabled. ...
Near line 313: Possible spelling mistake found.
Context: ...elect item is disabled. Based on selectdisabledKeysprop. - data-selected: When the ...
Near line 314: This sentence does not start with an uppercase letter.
Context: ...ased on selectdisabledKeysprop. - data-selected: When the select item is selected. ...
Near line 315: Possible spelling mistake found.
Context: ...elect item is selected. Based on selectselectedKeysprop. - data-hover: When the sel...
Near line 316: This sentence does not start with an uppercase letter.
Context: ...ased on selectselectedKeysprop. - data-hover: When the select item is being hove...
Near line 317: Unpaired symbol: ‘]’ seems to be missing
Context: ... select item is being hovered. Based on [useHover](https://react-spectrum.adobe.c...
Near line 317: Possible spelling mistake found.
Context: ...select item is being hovered. Based on [useHover](https://react-spectrum.adobe.com/react...
Near line 319: Unpaired symbol: ‘]’ seems to be missing
Context: ...en the select item is pressed. Based on [usePress](https://react-spectrum.adobe.c...
Near line 319: Possible spelling mistake found.
Context: ...n the select item is pressed. Based on [usePress](https://react-spectrum.adobe.com/react...
Near line 321: Possible spelling mistake found.
Context: ...select item is being focused. Based on [useFocusRing](https://react-spectrum.adobe.com/react...
Near line 322: This sentence does not start with an uppercase letter.
Context: ....com/react-aria/useFocusRing.html). - data-focus-visible: When the select item is being focu...
Near line 323: Possible spelling mistake found.
Context: ...ng focused with the keyboard. Based on [useFocusRing](https://react-spectrum.adobe.com/react...
Near line 329: Possible spelling mistake found.
Context: ...assistive technology as a button with a listbox popup using ARIA (combined with [Listbo...
Near line 329: Possible spelling mistake found.
Context: ...istbox popup using ARIA (combined with Listbox). - Support ...
Near line 332: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...pport for selecting multiple options. - Support for disabled options. - Support for sec...
Near line 333: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...ions. - Support for disabled options. - Support for sections. - Labeling support for ac...
Near line 338: Possible spelling mistake found.
Context: ...ent. - Keyboard support for opening the listbox using the arrow keys, including automat...
Near line 339: Possible spelling mistake found.
Context: ...g the first or last item accordingly. - Typeahead to allow selecting options by typing te...
Near line 339: Possible spelling mistake found.
Context: ...y typing text, even without opening the listbox. - Browser autofill integration via a h...
Near line 342: Possible spelling mistake found.
Context: ...ftware keyboard. - Mobile screen reader listbox dismissal support. #...
Near line 350: Possible typo: you repeated a whitespace
Context: ...> ## API ### Select Props | Attribute | Type ...
Near line 350: Possible typo: you repeated a whitespace
Context: ...ps | Attribute | Type | Description ...
Near line 350: Possible typo: you repeated a whitespace
Context: ... | Description | Default | | ---------------...
Near line 350: Possible typo: you repeated a whitespace
Context: ... | Default | | --------------------------- | ------...
Near line 352: Possible typo: you repeated a whitespace
Context: ...---- | ------------------ | | children* |ReactNode[]...
Near line 352: Possible spelling mistake found.
Context: ...----- | | children* |ReactNode[]...
Near line 352: Possible typo: you repeated a whitespace
Context: ...ldren* |ReactNode[]| The children to render. Usually a list...
Near line 352: Consider adding a comma after ‘Usually’ for more clarity.
Context: ... | The children to render. Usually a list ofSelectItemand `SelectSecti...
Near line 352: Possible spelling mistake found.
Context: ...e children to render. Usually a list ofSelectItemandSelectSectionelements. ...
Near line 352: Possible spelling mistake found.
Context: ...der. Usually a list ofSelectItemandSelectSectionelements. ...
Near line 352: Possible typo: you repeated a whitespace
Context: ...lectItemandSelectSection` elements. | - | | items ...
Near line 352: Possible typo: you repeated a whitespace
Context: ...s. | - | | items | [`Iter...
Near line 353: Possible typo: you repeated a whitespace
Context: ... | - | | items | [Iterable<T>](https://developer.mozi...
Near line 353: The word ‘Iterable<T’ is not standard English. Did you mean “Iterable’T” (curly apostrophe) or “Iterable'T” (straight apostrophe)?
Context: ... | | items | [Iterable<T>](https://developer.mozilla.org/en-US/...
Near line 353: Possible typo: you repeated a whitespace
Context: ...avaScript/Reference/Iteration_protocols) | Item objects in the select. (dynamic) ...
Near line 353: Possible typo: you repeated a whitespace
Context: ... | Item objects in the select. (dynamic) | - | | selectionMode ...
Near line 353: Possible typo: you repeated a whitespace
Context: ... | - | | selectionMode | `singl...
Near line 354: Possible spelling mistake found.
Context: ... | - | | selectionMode |single|multiple...
Near line 354: Possible typo: you repeated a whitespace
Context: ... | - | | selectionMode |single|multiple...
Near line 354: Possible typo: you repeated a whitespace
Context: ...e |single|multiple| The type of selection that is allowed ...
Near line 354: Possible typo: you repeated a whitespace
Context: ...tion that is allowed in the collection. | - | | selectedKeys ...
Near line 354: Possible typo: you repeated a whitespace
Context: ... | - | | selectedKeys |all...
Near line 355: Possible spelling mistake found.
Context: ... | - | | selectedKeys |all|React.Key[]...
Near line 355: Possible typo: you repeated a whitespace
Context: ... | - | | selectedKeys |all|React.Key[]...
Near line 355: Add a space between sentences.
Context: ... selectedKeys |all|React.Key[]...
Near line 355: Possible typo: you repeated a whitespace
Context: ... |all|React.Key[]| The currently selected keys in the col...
Near line 355: Possible typo: you repeated a whitespace
Context: ...ed keys in the collection (controlled). | - | | disabledKeys ...
Near line 355: Possible typo: you repeated a whitespace
Context: ... | - | | disabledKeys |all...
Near line 356: Possible spelling mistake found.
Context: ... | - | | disabledKeys |all|React.Key[]...
Near line 356: Possible typo: you repeated a whitespace
Context: ... | - | | disabledKeys |all|React.Key[]...
Near line 356: Add a space between sentences.
Context: ... disabledKeys |all|React.Key[]...
Near line 356: Possible typo: you repeated a whitespace
Context: ... |all|React.Key[]| The item keys that are disabled. These...
Near line 356: Possible typo: you repeated a whitespace
Context: ... focused, or otherwise interacted with. | - | | defaultSelected...
Near line 356: Possible typo: you repeated a whitespace
Context: ...wise interacted with. | - | | defaultSelectedKeys |all...
Near line 357: Possible spelling mistake found.
Context: ... | - | | defaultSelectedKeys |all|React.Key[]...
Near line 357: Possible typo: you repeated a whitespace
Context: ... | | defaultSelectedKeys |all|React.Key[]...
Near line 357: Add a space between sentences.
Context: ... defaultSelectedKeys |all|React.Key[]...
Near line 357: Possible typo: you repeated a whitespace
Context: ...tedKeys |all|React.Key[]| The initial selected keys in the colle...
Near line 357: Possible typo: you repeated a whitespace
Context: ... keys in the collection (uncontrolled). | - | | variant ...
Near line 357: Possible typo: you repeated a whitespace
Context: ... | - | | variant |flat...
Near line 358: Possible typo: you repeated a whitespace
Context: ... | - | | variant |flat|bordered|faded| `un...
Near line 358: Possible typo: you repeated a whitespace
Context: ...|bordered|faded|underlined| The variant of the select. ...
Near line 358: Possible typo: you repeated a whitespace
Context: ... | The variant of the select. |flat| | color ...
Near line 358: Possible typo: you repeated a whitespace
Context: ... |flat| | color | `defau...
Near line 359: Possible typo: you repeated a whitespace
Context: ... |flat| | color |default|primary|secondary...
Near line 359: Possible typo: you repeated a whitespace
Context: ...y\|success\|warning\|danger` | The color of the select. ...
Near line 359: Possible typo: you repeated a whitespace
Context: ... | The color of the select. |default| | size ...
Near line 359: Possible typo: you repeated a whitespace
Context: ... |default| | size |sm...
Near line 360: Possible typo: you repeated a whitespace
Context: ... |default| | size |sm|md|lg...
Near line 360: Possible spelling mistake found.
Context: ... | | size |sm|md|lg...
Near line 360: Possible spelling mistake found.
Context: ...| size |sm|md|lg...
Near line 360: Possible typo: you repeated a whitespace
Context: ... |sm|md|lg| The size of the select. ...
Near line 360: Possible typo: you repeated a whitespace
Context: ... | The size of the select. |md| | radius ...
Near line 360: Possible spelling mistake found.
Context: ... |md| | radius ...
Near line 360: Possible typo: you repeated a whitespace
Context: ... |md| | radius |none...
Near line 361: Possible typo: you repeated a whitespace
Context: ... |md| | radius |none|sm|md|lg| `ful...
Near line 361: Possible spelling mistake found.
Context: ...radius |none|sm|md|lg|full...
Near line 361: Possible spelling mistake found.
Context: ... |none|sm|md|lg|full...
Near line 361: Possible typo: you repeated a whitespace
Context: ...none|sm|md|lg|full| The radius of the select. ...
Near line 361: Possible typo: you repeated a whitespace
Context: ... | The radius of the select. | - | | placeholder ...
Near line 361: Possible typo: you repeated a whitespace
Context: ... | - | | placeholder | `strin...
Near line 362: Possible typo: you repeated a whitespace
Context: ... | - | | placeholder |string...
Near line 362: Possible typo: you repeated a whitespace
Context: ...| placeholder |string| The placeholder of the select. ...
Near line 362: Possible typo: you repeated a whitespace
Context: ... | The placeholder of the select. |Select an option| | labelPlacement ...
Near line 363: Possible spelling mistake found.
Context: ... |Select an option| | labelPlacement |inside|outside|...
Near line 363: Possible typo: you repeated a whitespace
Context: ... |Select an option| | labelPlacement |inside|outside| `outside-left...
Near line 363: Possible typo: you repeated a whitespace
Context: ...inside|outside|outside-left| The position of the label. ...
Near line 363: Possible typo: you repeated a whitespace
Context: ... | The position of the label. |inside| | label ...
Near line 363: Possible typo: you repeated a whitespace
Context: ... |inside| | label | `React...
Near line 364: Possible typo: you repeated a whitespace
Context: ... |inside| | label |ReactNode...
Near line 364: Possible spelling mistake found.
Context: ... | | label |ReactNode...
Near line 364: Possible typo: you repeated a whitespace
Context: ...abel |ReactNode| The content to display as the label. ...
Near line 364: Possible typo: you repeated a whitespace
Context: ... | The content to display as the label. | - | | description ...
Near line 364: Possible typo: you repeated a whitespace
Context: ... | - | | description | `React...
Near line 365: Possible typo: you repeated a whitespace
Context: ... | - | | description |ReactNode...
Near line 365: Possible spelling mistake found.
Context: ... | | description |ReactNode...
Near line 365: Possible typo: you repeated a whitespace
Context: ...escription |ReactNode| A description for the select. Provides...
Near line 365: Possible typo: you repeated a whitespace
Context: ...ecific requirements for what to choose. | - | | errorMessage ...
Near line 365: Possible typo: you repeated a whitespace
Context: ...at to choose. | - | | errorMessage | `React...
Near line 366: Possible spelling mistake found.
Context: ... | - | | errorMessage |ReactNode| `((v: V...
Near line 366: Possible typo: you repeated a whitespace
Context: ... | - | | errorMessage |ReactNode| `((v: ValidationResult)...
Near line 366: Possible spelling mistake found.
Context: ... | | errorMessage |ReactNode| `((v: ValidationResult) => ReactNod...
Near line 366: Do you wish to insert an arrow?
Context: ...Message |ReactNode|((v: ValidationResult) => ReactNode)...
Near line 366: Possible typo: you repeated a whitespace
Context: ...|((v: ValidationResult) => ReactNode)| An error message for the select. ...
Near line 366: Possible typo: you repeated a whitespace
Context: ... | An error message for the select. | - | | startContent ...
Near line 366: Possible typo: you repeated a whitespace
Context: ... | - | | startContent | `React...
Near line 367: Possible spelling mistake found.
Context: ... | - | | startContent |ReactNode...
Near line 367: Possible typo: you repeated a whitespace
Context: ... | - | | startContent |ReactNode...
Near line 367: Possible spelling mistake found.
Context: ... | | startContent |ReactNode...
Near line 367: Possible typo: you repeated a whitespace
Context: ...tartContent |ReactNode| Element to be rendered in the left sid...
Near line 367: In this case, the usual preposition with “side” is “on”, not “in”. Did you mean “on the left side”?
Context: ... | Element to be rendered in the left side of the select. ...
Near line 367: Possible typo: you repeated a whitespace
Context: ...endered in the left side of the select. | - | | endContent ...
Near line 367: Possible typo: you repeated a whitespace
Context: ... | - | | endContent | `React...
Near line 368: Possible spelling mistake found.
Context: ... | - | | endContent |ReactNode...
Near line 368: Possible typo: you repeated a whitespace
Context: ... | - | | endContent |ReactNode...
Near line 368: Possible spelling mistake found.
Context: ... | | endContent |ReactNode...
Near line 368: Possible typo: you repeated a whitespace
Context: ...ndContent |ReactNode| Element to be rendered in the right si...
Near line 368: In this case, the usual preposition with “side” is “on”, not “in”. Did you mean “on the right side”?
Context: ... | Element to be rendered in the right side of the select. ...
Near line 368: Possible typo: you repeated a whitespace
Context: ...ndered in the right side of the select. | - | | selectorIcon ...
Near line 368: Possible typo: you repeated a whitespace
Context: ... | - | | selectorIcon | `React...
Near line 369: Possible spelling mistake found.
Context: ... | - | | selectorIcon |ReactNode...
Near line 369: Possible typo: you repeated a whitespace
Context: ... | - | | selectorIcon |ReactNode...
Near line 369: Possible spelling mistake found.
Context: ... | | selectorIcon |ReactNode...
Near line 369: Possible typo: you repeated a whitespace
Context: ...electorIcon |ReactNode| Element to be rendered as the selector...
Near line 369: Possible typo: you repeated a whitespace
Context: ...nt to be rendered as the selector icon. | - | | scrollRef ...
Near line 369: Possible typo: you repeated a whitespace
Context: ... | - | | scrollRef | `React...
Near line 370: Possible spelling mistake found.
Context: ... | - | | scrollRef | `React.RefObject<HT...
Near line 370: Possible typo: you repeated a whitespace
Context: ... | - | | scrollRef |React.RefObject<HTMLElement>...
Near line 370: Add a space between sentences.
Context: ... | | scrollRef |React.RefObject<HTMLElement>...
Near line 370: Possible typo: you repeated a whitespace
Context: ... |React.RefObject<HTMLElement>| A ref to the scrollable element. ...
Near line 370: Possible typo: you repeated a whitespace
Context: ... | A ref to the scrollable element. | - | | spinnerRef ...
Near line 370: Possible typo: you repeated a whitespace
Context: ... | - | | spinnerRef | `React...
Near line 371: Possible spelling mistake found.
Context: ... | - | | spinnerRef | `React.RefObject<HTM...
Near line 371: Possible typo: you repeated a whitespace
Context: ... | - | | spinnerRef |React.RefObject<HTMLElement>...
Near line 371: Add a space between sentences.
Context: ... | | spinnerRef |React.RefObject<HTMLElement>...
Near line 371: Possible typo: you repeated a whitespace
Context: ... |React.RefObject<HTMLElement>| A ref to the spinner element. ...
Near line 371: Possible typo: you repeated a whitespace
Context: ... | A ref to the spinner element. | - | | fullWidth ...
Near line 371: Possible typo: you repeated a whitespace
Context: ... | - | | fullWidth | `boole...
Near line 372: Possible spelling mistake found.
Context: ... | - | | fullWidth |boolean...
Near line 372: Possible typo: you repeated a whitespace
Context: ... | - | | fullWidth |boolean...
Near line 372: Possible typo: you repeated a whitespace
Context: ... fullWidth |boolean| Whether the select should take up the ...
Near line 372: Possible typo: you repeated a whitespace
Context: ...should take up the width of its parent. |true| | isOpen ...
Near line 372: Possible typo: you repeated a whitespace
Context: ... |true| | isOpen | `boole...
Near line 373: Possible spelling mistake found.
Context: ... |true| | isOpen |boolean...
Near line 373: Possible typo: you repeated a whitespace
Context: ... |true| | isOpen |boolean...
Near line 373: Possible typo: you repeated a whitespace
Context: ... isOpen |boolean| Whether the select is open by default ...
Near line 373: Possible typo: you repeated a whitespace
Context: ...select is open by default (controlled). | - | | defaultOpen ...
Near line 373: Possible typo: you repeated a whitespace
Context: ... | - | | defaultOpen | `boole...
Near line 374: Possible spelling mistake found.
Context: ... | - | | defaultOpen |boolean...
Near line 374: Possible typo: you repeated a whitespace
Context: ... | - | | defaultOpen |boolean...
Near line 374: Possible typo: you repeated a whitespace
Context: ... defaultOpen |boolean| Whether the select is open by default ...
Near line 374: Possible typo: you repeated a whitespace
Context: ...lect is open by default (uncontrolled). | - | | isRequired ...
Near line 374: Possible typo: you repeated a whitespace
Context: ... | - | | isRequired | `boole...
Near line 375: Possible spelling mistake found.
Context: ... | - | | isRequired |boolean...
Near line 375: Possible typo: you repeated a whitespace
Context: ... | - | | isRequired |boolean...
Near line 375: Possible typo: you repeated a whitespace
Context: ... isRequired |boolean| Whether user select is required on the...
Near line 375: Possible typo: you repeated a whitespace
Context: ...d on the select before form submission. |false| | isDisabled ...
Near line 375: Possible typo: you repeated a whitespace
Context: ... |false| | isDisabled | `boole...
Near line 376: Possible spelling mistake found.
Context: ... |false| | isDisabled |boolean...
Near line 376: Possible typo: you repeated a whitespace
Context: ... |false| | isDisabled |boolean...
Near line 376: Possible typo: you repeated a whitespace
Context: ... isDisabled |boolean| Whether the select is disabled. ...
Near line 376: Possible typo: you repeated a whitespace
Context: ... | Whether the select is disabled. |false| | isMultiline ...
Near line 376: Possible typo: you repeated a whitespace
Context: ... |false| | isMultiline | `boole...
Near line 377: Possible spelling mistake found.
Context: ... |false| | isMultiline |boolean...
Near line 377: Possible typo: you repeated a whitespace
Context: ... |false| | isMultiline |boolean...
Near line 377: Possible typo: you repeated a whitespace
Context: ... isMultiline |boolean| Whether the select should allow multip...
Near line 377: Possible typo: you repeated a whitespace
Context: ...ct should allow multiple lines of text. |false| | isInvalid ...
Near line 377: Possible typo: you repeated a whitespace
Context: ... |false| | isInvalid | `boole...
Near line 378: Possible spelling mistake found.
Context: ... |false| | isInvalid |boolean...
Near line 378: Possible typo: you repeated a whitespace
Context: ... |false| | isInvalid |boolean...
Near line 378: Possible typo: you repeated a whitespace
Context: ... isInvalid |boolean| Whether the select is invalid. ...
Near line 378: Possible typo: you repeated a whitespace
Context: ... | Whether the select is invalid. |false| | validationState...
Near line 378: Possible typo: you repeated a whitespace
Context: ... |false| | validationState | `valid...
Near line 379: Possible spelling mistake found.
Context: ... |false| | validationState |valid|invalid...
Near line 379: Possible typo: you repeated a whitespace
Context: ...|false| | validationState |valid|invalid...
Near line 379: Possible typo: you repeated a whitespace
Context: ...State |valid|invalid| Whether the select should display its ...
Near line 379: Possible spelling mistake found.
Context: ... visual styling. (Deprecated) use isInvalid instead. | - | | sho...
Near line 379: Possible typo: you repeated a whitespace
Context: ...ecated**) use isInvalid instead. | - | | showScrollIndicators | `boole...
Near line 380: Possible spelling mistake found.
Context: ...lid** instead. | - | | showScrollIndicators |boolean...
Near line 380: Possible typo: you repeated a whitespace
Context: ... | | showScrollIndicators |boolean...
Near line 380: Possible typo: you repeated a whitespace
Context: ... showScrollIndicators |boolean| Whether the select should show scroll ...
Near line 380: Possible spelling mistake found.
Context: ... should show scroll indicators when the listbox is scrollable. ...
Near line 380: Possible typo: you repeated a whitespace
Context: ...icators when the listbox is scrollable. |true| | autoFocus ...
Near line 380: Possible typo: you repeated a whitespace
Context: ... |true| | autoFocus | `boole...
Near line 381: Possible spelling mistake found.
Context: ... |true| | autoFocus |boolean...
Near line 381: Possible typo: you repeated a whitespace
Context: ... |true| | autoFocus |boolean...
Near line 381: Possible typo: you repeated a whitespace
Context: ... autoFocus |boolean| Whether the select should be focused o...
Near line 381: Possible typo: you repeated a whitespace
Context: ...t should be focused on the first mount. |false| | disallowEmptySe...
Near line 381: Possible typo: you repeated a whitespace
Context: ... |false| | disallowEmptySelection | `boole...
Near line 382: Possible spelling mistake found.
Context: ... |false| | disallowEmptySelection |boolean...
Near line 382: Possible typo: you repeated a whitespace
Context: ...e| | disallowEmptySelection |boolean` ...
Near line 382: Possible typo: you repeated a whitespace
Context: ... disallowEmptySelection |boolean| Whether the collection allows empty se...
Near line 382: Possible typo: you repeated a whitespace
Context: ... the collection allows empty selection. |false| | disableAnimatio...
Near line 382: Possible typo: you repeated a whitespace
Context: ... |false| | disableAnimation | `boole...
Near line 383: Possible spelling mistake found.
Context: ... |false| | disableAnimation |boolean...
Near line 383: Possible typo: you repeated a whitespace
Context: ...false| | disableAnimation |boolean...
Near line 383: Possible typo: you repeated a whitespace
Context: ... disableAnimation |boolean| Whether the select should be animated....
Near line 383: Possible typo: you repeated a whitespace
Context: ... Whether the select should be animated. |true| | disableSelector...
Near line 383: Possible typo: you repeated a whitespace
Context: ... |true| | disableSelectorIconRotation | `boole...
Near line 384: Possible spelling mistake found.
Context: ... |true| | disableSelectorIconRotation |boolean...
Near line 384: Possible typo: you repeated a whitespace
Context: ... disableSelectorIconRotation |boolean| Whether the select should disable the ...
Near line 384: Possible typo: you repeated a whitespace
Context: ...able the rotation of the selector icon. |false| | popoverProps ...
Near line 384: Possible typo: you repeated a whitespace
Context: ... |false| | popoverProps | [Popov...
Near line 385: Possible spelling mistake found.
Context: ... |false| | popoverProps | [PopoverProps](/docs/c...
Near line 385: Possible typo: you repeated a whitespace
Context: ... |false| | popoverProps | [PopoverProps](/docs/components/popove...
Near line 385: Possible spelling mistake found.
Context: ... | | popoverProps | PopoverProps ...
Near line 385: Possible typo: you repeated a whitespace
Context: ...overProps](/docs/components/popover#api) | Props to be passed to the popover comp...
Near line 385: Possible typo: you repeated a whitespace
Context: ... to be passed to the popover component. | - | | listboxProps ...
Near line 385: Possible typo: you repeated a whitespace
Context: ... | - | | listboxProps | [Listb...
Near line 386: Possible spelling mistake found.
Context: ... | - | | listboxProps | [ListboxProps](/docs/c...
Near line 386: Possible typo: you repeated a whitespace
Context: ... | - | | listboxProps | [ListboxProps](/docs/components/listbo...
Near line 386: Possible spelling mistake found.
Context: ... | | listboxProps | ListboxProps ...
Near line 386: Possible typo: you repeated a whitespace
Context: ...tboxProps](/docs/components/listbox#api) | Props to be passed to the listbox comp...
Near line 386: Possible spelling mistake found.
Context: ... | Props to be passed to the listbox component. ...
Near line 386: Possible typo: you repeated a whitespace
Context: ... to be passed to the listbox component. | - | | scrollShadowPro...
Near line 386: Possible typo: you repeated a whitespace
Context: ... | - | | scrollShadowProps | [Scrol...
Near line 387: Possible spelling mistake found.
Context: ... | - | | scrollShadowProps | [ScrollShadowProps](/docs/c...
Near line 387: Possible typo: you repeated a whitespace
Context: ...- | | scrollShadowProps | [ScrollShadowProps](/docs/components/s...
Near line 387: Possible spelling mistake found.
Context: ... | | scrollShadowProps | ScrollShadowProps ...
Near line 387: Possible typo: you repeated a whitespace
Context: ...ops](/docs/components/scroll-shadow#api) | Props to be passed to the scroll shado...
Near line 387: Possible typo: you repeated a whitespace
Context: ... passed to the scroll shadow component. | - | | classNames ...
Near line 387: Possible typo: you repeated a whitespace
Context: ... | - | | classNames | `Recor...
Near line 388: Possible spelling mistake found.
Context: ... | - | | classNames | `Record<"base"｜ "lab...
Near line 388: Possible typo: you repeated a whitespace
Context: ... | - | | classNames | `Record<"base"｜ "label"｜ "trigger"｜ "m...
Near line 388: Possible spelling mistake found.
Context: ... | | classNames | `Record<"base"｜ "label"｜ "trigger"｜ "mainWrapper" ｜ "innerWrapper"｜ "selectorIcon" ｜ "va...
Near line 388: Only proper nouns start with an uppercase character (there are exceptions for headlines).
Context: ...scription" ｜ "errorMessage", string>` | Allows to set custom class names for the Selec...
Near line 388: Possible typo: you repeated a whitespace
Context: ...ustom class names for the Select slots. | - | ### Select Event...
Near line 388: Possible typo: you repeated a whitespace
Context: ... | - | ### Select Events | Attribute ...
Near line 392: Possible typo: you repeated a whitespace
Context: ... | ### Select Events | Attribute | Type ...
Near line 392: Possible typo: you repeated a whitespace
Context: ...elect Events | Attribute | Type | Description ...
Near line 392: Possible typo: you repeated a whitespace
Context: ... | Description | | ----------------- | ----------------...
Near line 394: Possible spelling mistake found.
Context: ...----------------------------------- | | onClose |() => void...
Near line 394: Possible typo: you repeated a whitespace
Context: ...---------------------------- | | onClose |() => void...
Near line 394: Do you wish to insert an arrow?
Context: ...--------------- | | onClose |() => void...
Near line 394: Possible typo: you repeated a whitespace
Context: ...--- | | onClose |() => void| Callback fired when the select popover...
Near line 394: Possible typo: you repeated a whitespace
Context: ...ired when the select popover is closed. | | onOpenChange | `(isOpen: boolea...
Near line 395: Possible spelling mistake found.
Context: ... | | onOpenChange |(isOpen: boolean) => void...
Near line 395: Possible typo: you repeated a whitespace
Context: ... | | onOpenChange |(isOpen: boolean) => void...
Near line 395: Do you wish to insert an arrow?
Context: ... | | onOpenChange |(isOpen: boolean) => void| Callback fire...
Near line 395: Possible typo: you repeated a whitespace
Context: ...hange |(isOpen: boolean) => void| Callback fired when the select popover...
Near line 395: Possible typo: you repeated a whitespace
Context: ...the select popover is opened or closed. | | onSelectionChange | `(keys: React.Ke...
Near line 396: Possible spelling mistake found.
Context: ...or closed. | | onSelectionChange |(keys: React.Key[]) => void...
Near line 396: Do you wish to insert an arrow?
Context: ... | | onSelectionChange |(keys: React.Key[]) => void| Callback fired ...
Near line 396: Possible typo: you repeated a whitespace
Context: ...onChange |(keys: React.Key[]) => void| Callback fired when the selected keys ...
Near line 396: Possible typo: you repeated a whitespace
Context: ...ck fired when the selected keys change. | | onChange | `React.ChangeEve...
Near line 397: Possible spelling mistake found.
Context: ... | | onChange | `React.ChangeEvent<HTMLSelec...
Near line 397: Possible typo: you repeated a whitespace
Context: ... | | onChange |React.ChangeEvent<HTMLSelectElement>...
Near line 397: Add a space between sentences.
Context: ... | | onChange |React.ChangeEvent<HTMLSelectElement>| Native sel...
Near line 397: Possible typo: you repeated a whitespace
Context: ...|React.ChangeEvent<HTMLSelectElement>| Native select change event, fired when...
Near line 397: Possible typo: you repeated a whitespace
Context: ... fired when the selected value changes. | | renderValue | [RenderValueFunc...
Near line 398: Possible spelling mistake found.
Context: ...ed value changes. | | renderValue | [RenderValueFunction](#render-v...
Near line 398: Possible typo: you repeated a whitespace
Context: ...anges. | | renderValue | [RenderValueFunction](#render-value-fu...
Near line 398: Possible spelling mistake found.
Context: ... | | renderValue | RenderValueFunction | Function to ...
Near line 402: Possible spelling mistake found.
Context: ...e selected item by default. | --- ### SelectItem Props Check the [ListboxItem](/docs/co...
Near line 404: Possible spelling mistake found.
Context: ... --- ### SelectItem Props Check the [ListboxItem](/docs/components/listbox#listboxitem-p...
Near line 406: Possible spelling mistake found.
Context: .../listbox#listboxitem-props) props. ### SelectItem Events Check the [ListboxItem](/docs/c...
Near line 408: Possible spelling mistake found.
Context: ...ops. ### SelectItem Events Check the [ListboxItem](/docs/components/listbox#listboxitem-e...
Near line 410: Possible spelling mistake found.
Context: ...istbox#listboxitem-events) events. ### SelectSection Props Check the [ListboxSection](/docs...
Near line 412: Possible spelling mistake found.
Context: ...s. ### SelectSection Props Check the [ListboxSection](/docs/components/listbox#listboxsectio...
Additional comments not posted (52)
apps/docs/content/components/select/dynamic.ts (2)
2-14: The update fromvaluetokeyin theanimalsarray aligns with the PR's objectives to handle numeric keys correctly.
28-28: Ensure that theSelectItemcomponent correctly handles thekeyprop as intended in the new implementation.Verification successful
The verification process has confirmed that the
SelectItemcomponent is consistently used with thekeyprop across various files in the repository. This includes the specific fileapps/docs/content/components/select/dynamic.tsmentioned in the review comment, as well as numerous other instances across the codebase. Each usage correctly includes akeyprop, which is essential for React's efficient rendering of lists.Therefore, the implementation of the
keyprop in theSelectItemcomponent usage aligns with best practices and the expectations set in the review comment.
- File Locations with Correct
keyProp Usage:
apps/docs/content/components/select/without-scroll-shadow.tsapps/docs/content/components/select/variants.tsapps/docs/content/components/select/usage.tsapps/docs/content/components/select/start-content.tsapps/docs/content/components/select/single-controlled.tsapps/docs/content/components/select/sizes.tsapps/docs/content/components/select/single-controlled-onchange.tsapps/docs/content/components/select/required.tsapps/docs/content/components/select/sections.tsapps/docs/content/components/select/radius.tsapps/docs/content/components/select/open-state.tsapps/docs/content/components/select/multiple.tsapps/docs/content/components/select/multiple-controlled-onchange.tsapps/docs/content/components/select/multiple-controlled.tsapps/docs/content/components/select/label-placements.tsapps/docs/content/components/select/multiple-chips.tsapps/docs/content/components/select/item-start-content.tsapps/docs/content/components/select/error-message.tsapps/docs/content/components/select/disabled.tsapps/docs/content/components/select/dynamic.tsapps/docs/content/components/select/disabled-items.tsapps/docs/content/components/select/description.tsapps/docs/content/components/select/custom-selector-icon.tsapps/docs/content/components/select/custom-styles.tsapps/docs/content/components/select/custom-render-value.tsapps/docs/content/components/select/custom-sections-style.tsapps/docs/content/components/select/colors.tsapps/docs/content/components/select/async-loading-items.tsapps/docs/content/components/select/custom-items.tsScripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that the `SelectItem` component correctly handles the `key` prop. # Test: Search for the `SelectItem` component usage. Expect: Correct handling of the `key` prop. rg --type js $'SelectItem'Length of output: 25
Script:
#!/bin/bash # Broaden the search to include all file types and ensure the search is case-insensitive rg -i 'SelectItem' --files-with-matchesLength of output: 2026
Script:
#!/bin/bash # Extract the usage of `SelectItem` from select-related files to check for `key` prop handling rg -i 'SelectItem' apps/docs/content/components/select/*.tsLength of output: 17123
apps/docs/content/components/select/multiple.ts (2)
2-14: The update fromvaluetokeyin theanimalsarray aligns with the PR's objectives to handle numeric keys correctly.
29-29: Ensure that theSelectItemcomponent correctly handles thekeyprop as intended in the new implementation.Verification successful
The search results confirm that the
SelectItemcomponent is widely used across various files in the codebase, and consistently receives akeyprop as part of its usage. This includes multiple instances within theapps/docs/content/components/select/directory, where the component is used in various scenarios and consistently receives thekeyprop, aligning with the intended implementation as mentioned in the review comment.Given this consistent usage pattern across multiple files and scenarios, it can be concluded that the
SelectItemcomponent is correctly handling thekeyprop as intended in the new implementation.
- File Locations and Usage Examples:
apps/docs/content/components/select/multiple.tson line 29apps/docs/content/components/select/variants.tson lines 29, 31apps/docs/content/components/select/without-scroll-shadow.tson line 29- Many other files in the
apps/docs/content/components/select/directory and tests.Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that the `SelectItem` component correctly handles the `key` prop. # Test: Search for the `SelectItem` component usage. Expect: Correct handling of the `key` prop. rg --type js $'SelectItem'Length of output: 25
Script:
#!/bin/bash # Description: Verify that the `SelectItem` component correctly handles the `key` prop. # Test: Search for the `SelectItem` component usage in TypeScript files. Expect: Correct handling of the `key` prop. rg --type ts $'SelectItem'Length of output: 26771
apps/docs/content/components/select/disabled.ts (2)
2-14: The update fromvaluetokeyin theanimalsarray aligns with the PR's objectives to handle numeric keys correctly.
30-30: Ensure that theSelectItemcomponent correctly handles thekeyprop as intended in the new implementation.apps/docs/content/components/select/required.ts (2)
2-14: The update fromvaluetokeyin theanimalsarray aligns with the PR's objectives to handle numeric keys correctly.
30-30: Ensure that theSelectItemcomponent correctly handles thekeyprop as intended in the new implementation.Verification successful
The verification script aimed to check the usage of the
SelectItemcomponent and specifically how it handles thekeyprop. However, the script did not return any results. This could imply that theSelectItemcomponent is not used in any JavaScript files within the repository, or there might be an issue with the search parameters or file types specified.Given this situation, it's prudent to re-run the search with adjusted parameters to ensure we're not missing any files or usage instances. This will help us confirm whether the
SelectItemcomponent is indeed absent or if it's being used in a way that wasn't captured by the initial script.
The expanded search has successfully identified multiple files across the repository where the
SelectItemcomponent is used. This includes various documentation, example, and component files, indicating that the component is indeed widely utilized within the project.To specifically verify how the
SelectItemcomponent handles thekeyprop, as mentioned in the original review comment, we should inspect a few of these files whereSelectItemis likely to be implemented or demonstrated. This will help us understand if thekeyprop is being handled correctly in the context of the new implementation.
The examination of the
SelectItemcomponent's implementation and its usage in test files confirms that thekeyprop is consistently used and handled as expected. The component is imported and utilized in various test scenarios where eachSelectItemis distinctly identified by akeyprop, which is crucial for React's efficient rendering and re-rendering of lists.From the provided script outputs, it's evident that the
keyprop is being correctly applied toSelectIteminstances in multiple test cases, ensuring that each item can be uniquely identified within the virtual DOM. This is a standard and important practice in React for items in lists, which helps in tracking and managing updates to the list efficiently.Given this information, we can conclude that the
SelectItemcomponent handles thekeyprop appropriately across different usage contexts within the codebase.
- File: packages/components/select/src/index.ts - The component is exported properly, ensuring availability for use in other parts of the application.
- File: packages/components/select/tests/select.test.tsx - Multiple test cases demonstrate the correct usage of the
keyprop withSelectItem, confirming that the implementation aligns with React's expected practices for list items.Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that the `SelectItem` component correctly handles the `key` prop. # Test: Search for the `SelectItem` component usage. Expect: Correct handling of the `key` prop. rg --type js $'SelectItem'Length of output: 25
Script:
#!/bin/bash # Broaden the search to include all files, not just those with a .js extension, as the component might be used in other file types like .jsx or .tsx. rg 'SelectItem' --files-with-matchesLength of output: 2023
Script:
#!/bin/bash # Inspect a few specific files where `SelectItem` is likely to be implemented or demonstrated. # We are particularly interested in the actual component implementation and test files. # Display relevant sections from the component implementation file. cat packages/components/select/src/index.ts | grep -C 5 'SelectItem' # Display relevant sections from the test file. cat packages/components/select/__tests__/select.test.tsx | grep -C 5 'SelectItem'Length of output: 6426
apps/docs/content/components/select/disabled-items.ts (2)
2-14: The update fromvaluetokeyin theanimalsarray aligns with the PR's objectives to handle numeric keys correctly.
29-29: Ensure that theSelectItemcomponent correctly handles thekeyprop as intended in the new implementation.Verification successful
The initial script aimed to verify the correct handling of the
keyprop in theSelectItemcomponent by searching for its usage across JavaScript files. However, the script did not produce any results, indicating that no instances ofSelectItemwere found in the JavaScript files of the repository. This could mean that the component is either not used or the search parameters were too restrictive.Given this outcome, it's necessary to broaden the search to ensure that no instances of the
SelectItemcomponent are overlooked. This can be achieved by adjusting the search parameters or extending the search to include other file types that might contain relevant code (e.g., TypeScript files if the project uses TypeScript).
The attempt to broaden the search for the
SelectItemcomponent by including both JavaScript and TypeScript files encountered a syntax error in thergcommand, specifically with the unrecognized file type parameter. This error prevented the execution of the search and thus no results were obtained.To correct this and effectively search for the
SelectItemcomponent across both JavaScript and TypeScript files, the script needs to be adjusted to use the correct syntax for specifying multiple file types.
The search results confirm that the
SelectItemcomponent is widely used across various files in the repository, particularly within thestories,tests, anddocsdirectories. The usage consistently involves passing akeyprop to theSelectItemcomponent, which aligns with the expected behavior as mentioned in the review comment.Given this information, it appears that the
SelectItemcomponent is indeed handling thekeyprop as intended across multiple instances in the codebase. Therefore, the implementation seems correct based on the usage patterns observed in the search results.Conclusion:
TheSelectItemcomponent correctly handles thekeyprop as intended in the new implementation. The usage across the codebase is consistent and aligns with the expected behavior.Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that the `SelectItem` component correctly handles the `key` prop. # Test: Search for the `SelectItem` component usage. Expect: Correct handling of the `key` prop. rg --type js $'SelectItem'Length of output: 25
Script:
#!/bin/bash # Broadening the search to include TypeScript files and ensure all instances of SelectItem are found. rg --type js,ts 'SelectItem'Length of output: 58
Script:
#!/bin/bash # Correcting the syntax error and searching for the SelectItem component in both JavaScript and TypeScript files. rg 'SelectItem' --type js --type tsLength of output: 26781
apps/docs/content/components/select/description.ts (2)
2-14: The update fromvaluetokeyin theanimalsarray aligns with the PR's objectives to handle numeric keys correctly.
30-30: Ensure that theSelectItemcomponent correctly handles thekeyprop as intended in the new implementation.Verification successful
The expanded search for the
SelectItemcomponent across all file types has successfully located multiple instances where theSelectItemcomponent is used with thekeyprop. This confirms that theSelectItemcomponent is indeed handling thekeyprop as intended across various files in the codebase.Here are some specific files and lines where the
keyprop is used withSelectItem:
apps/docs/content/components/select/custom-sections-style.ts(Lines 2-10)apps/docs/content/components/select/item-start-content.ts(Lines 2-10)apps/docs/content/components/select/multiple-controlled-onchange.ts(Lines 2-10)apps/docs/content/components/select/radius.ts(Lines 2-10)apps/docs/content/components/select/single-controlled.ts(Lines 2-10)apps/docs/content/components/select/sizes.ts(Lines 2-10)apps/docs/content/components/select/without-scroll-shadow.ts(Lines 2-10)apps/docs/content/components/select/variants.ts(Lines 2-10)apps/docs/content/components/select/start-content.ts(Lines 2-10)apps/docs/content/components/select/usage.ts(Lines 2-10)apps/docs/content/components/select/dynamic.ts(Lines 2-10)apps/docs/content/components/select/required.ts(Lines 2-10)apps/docs/content/components/select/open-state.ts(Lines 2-10)apps/docs/content/components/select/multiple.ts(Lines 2-10)apps/docs/content/components/select/multiple-controlled.ts(Lines 2-10)apps/docs/content/components/select/label-placements.ts(Lines 2-10)apps/docs/content/components/select/error-message.ts(Lines 2-10)apps/docs/content/components/select/single-controlled-onchange.ts(Lines 2-10)apps/docs/content/components/select/disabled-items.ts(Lines 2-10)apps/docs/content/components/select/description.ts(Lines 2-10)apps/docs/content/components/select/custom-selector-icon.ts(Lines 2-10)apps/docs/content/components/select/colors.ts(Lines 2-10)apps/docs/content/components/select/sections.ts(Lines 2-10)apps/docs/content/components/select/multiple-chips.ts(Lines 2-10)apps/docs/content/components/select/custom-styles.ts(Lines 2-10)apps/docs/content/components/select/custom-render-value.ts(Lines 2-10)apps/docs/content/components/select/custom-items.ts(Lines 2-10)apps/docs/content/components/select/async-loading-items.ts(Lines 2-10)apps/docs/content/components/select/disabled.ts(Lines 2-10)This comprehensive usage across various files and contexts within the codebase confirms that the
SelectItemcomponent is consistently using thekeyprop as expected.Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that the `SelectItem` component correctly handles the `key` prop. # Test: Search for the `SelectItem` component usage. Expect: Correct handling of the `key` prop. rg --type js $'SelectItem'Length of output: 25
Script:
#!/bin/bash # Broaden the search for `SelectItem` to include all files, not just JavaScript, and check for possible aliases or indirect references. rg 'SelectItem' -t allLength of output: 27179
apps/docs/content/components/select/without-scroll-shadow.ts (2)
2-14: The update fromvaluetokeyin theanimalsarray aligns with the PR's objectives to handle numeric keys correctly.
32-32: Ensure that theSelectItemcomponent correctly handles thekeyprop as intended in the new implementation.Verification successful
The expanded search for the
SelectItemcomponent across the codebase has successfully identified multiple instances where thekeyprop is being used. This confirms that theSelectItemcomponent is widely utilized and consistently handles thekeyprop as expected in various files, including the specific fileapps/docs/content/components/select/without-scroll-shadow.ts.Given this information, it is evident that the
SelectItemcomponent is correctly handling thekeyprop across different implementations in the codebase. Therefore, the original review comment has been addressed, and the implementation aligns with the expected usage of thekeyprop.
- File:
apps/docs/content/components/select/without-scroll-shadow.ts
- Usage:
<SelectItem key={animal.key}>Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that the `SelectItem` component correctly handles the `key` prop. # Test: Search for the `SelectItem` component usage. Expect: Correct handling of the `key` prop. rg --type js $'SelectItem'Length of output: 25
Script:
#!/bin/bash # Broaden the search for `SelectItem` across all file types to ensure it's not missed due to incorrect file type specification. rg 'SelectItem'Length of output: 28494
apps/docs/content/components/select/radius.ts (2)
2-14: Updatedanimalsdata structure to usekeyinstead ofvalue.This change aligns with the PR's objective to maintain type consistency by ensuring numeric keys are handled correctly.
41-41: Correct usage ofkeyinSelectItem.This ensures that the
SelectItemcomponent correctly receives thekeyas intended, supporting the overall goal of maintaining type integrity.apps/docs/content/components/select/usage.ts (3)
2-14: Updatedanimalsdata structure to usekeyinstead ofvalue.Consistent with the PR's objective, this change ensures that numeric keys are preserved, enhancing type consistency across the component.
28-28: Correct usage ofkeyinSelectItemfor the firstSelectcomponent.This change is crucial for maintaining the integrity of key handling within the component.
39-39: Correct usage ofkeyinSelectItemfor the secondSelectcomponent.Ensures that the
SelectItemcomponent correctly receives thekey, aligning with the PR's goals.apps/docs/content/components/select/colors.ts (2)
2-14: Updatedanimalsdata structure to usekeyinstead ofvalue.This change is consistent with the PR's objective to handle numeric keys correctly, enhancing type consistency.
42-42: Correct usage ofkeyinSelectItem.This ensures that the
SelectItemcomponent correctly receives thekeyas intended, supporting the overall goal of maintaining type integrity.apps/docs/content/components/select/open-state.ts (2)
2-14: Updatedanimalsdata structure to usekeyinstead ofvalue.This change aligns with the PR's objective to maintain type consistency by ensuring numeric keys are handled correctly.
34-34: Correct usage ofkeyinSelectItem.This ensures that the
SelectItemcomponent correctly receives thekeyas intended, supporting the overall goal of maintaining type integrity.apps/docs/content/components/select/error-message.ts (2)
2-14: Updatedanimalsdata structure to usekeyinstead ofvalue.This change is consistent with the PR's objective to handle numeric keys correctly, enhancing type consistency.
40-40: Correct usage ofkeyinSelectItem.This ensures that the
SelectItemcomponent correctly receives thekeyas intended, supporting the overall goal of maintaining type integrity.apps/docs/content/components/select/sizes.ts (3)
2-14: Updatedanimalsdata structure to usekeyinstead ofvalue.This change is consistent with the PR's objective to handle numeric keys correctly, enhancing type consistency.
33-33: Correct usage ofkeyinSelectItemfor the firstSelectcomponent.This change is crucial for maintaining the integrity of key handling within the component.
45-45: Correct usage ofkeyinSelectItemfor the secondSelectcomponent.Ensures that the
SelectItemcomponent correctly receives thekey, aligning with the PR's goals.apps/docs/content/components/select/custom-selector-icon.ts (2)
2-14: Updatedanimalsdata structure to usekeyinstead ofvalue.This change is consistent with the PR's objective to handle numeric keys correctly, enhancing type consistency.
53-53: Correct usage ofkeyinSelectItem.This ensures that the
SelectItemcomponent correctly receives thekeyas intended, supporting the overall goal of maintaining type integrity.apps/docs/content/components/select/variants.ts (3)
2-14: Updatedanimalsdata structure to usekeyinstead ofvalue.This change is consistent with the PR's objective to handle numeric keys correctly, enhancing type consistency.
33-33: Correct usage ofkeyinSelectItemfor the firstSelectcomponent.This change is crucial for maintaining the integrity of key handling within the component.
45-45: Correct usage ofkeyinSelectItemfor the secondSelectcomponent.Ensures that the
SelectItemcomponent correctly receives thekey, aligning with the PR's goals.apps/docs/content/components/select/single-controlled.ts (3)
2-14: Changes to theanimalsarray align with the PR's objectives to handle keys correctly.
34-34: The usage ofkeyinSelectItemis consistent with the updated data structure and PR objectives.Also applies to: 61-61
34-34: The TypeScript version of the App component correctly uses the updatedanimalsdata withkeyproperties.Also applies to: 61-61
apps/docs/content/components/select/label-placements.ts (2)
2-14: The updates to theanimalsarray are consistent across examples, correctly usingkeyas intended in the PR.
39-39: Consistent use ofkeyinSelectItemacross different label placements demonstrates thorough implementation of the PR's objectives.Also applies to: 58-58
apps/docs/content/components/select/multiple-controlled.ts (3)
2-14: Theanimalsdata structure is correctly updated to usekey, supporting the PR's goal of correct key handling inSelectcomponents.
34-34: Proper use ofkeyinSelectItemwithin a multiple selection context aligns with the updated data structure and PR objectives.Also applies to: 61-61
34-34: The TypeScript version of the App component correctly uses the updatedanimalsdata withkeyproperties in a multiple selection context.Also applies to: 61-61
apps/docs/content/components/select/single-controlled-onchange.ts (3)
2-14: Theanimalsdata structure is correctly updated to usekey, supporting the PR's goal of correct key handling inSelectcomponents.
38-38: Proper use ofkeyinSelectItemwithin anonChangeevent context aligns with the updated data structure and PR objectives.Also applies to: 69-69
38-38: The TypeScript version of the App component correctly uses the updatedanimalsdata withkeyproperties in anonChangeevent context.Also applies to: 69-69
apps/docs/content/components/select/multiple-controlled-onchange.ts (3)
2-14: Theanimalsdata structure is correctly updated to usekey, supporting the PR's goal of correct key handling inSelectcomponents.
38-38: Proper use ofkeyinSelectItemwithin a multiple selectiononChangeevent context aligns with the updated data structure and PR objectives.Also applies to: 69-69
38-38: The TypeScript version of the App component correctly uses the updatedanimalsdata withkeyproperties in a multiple selectiononChangeevent context.Also applies to: 69-69
apps/docs/content/components/select/start-content.ts (2)
2-14: Theanimalsdata structure is correctly updated to usekey, supporting the PR's goal of correct key handling inSelectcomponents.
65-65: Proper use ofkeyinSelectItemwithin astartContentcontext aligns with the updated data structure and PR objectives.packages/components/select/src/select.tsx (1)
132-133: The adjustments in the rendering logic forrenderSelectedItemandendContentensure correct display and conditional rendering, aligning with the PR's objectives.packages/components/select/__tests__/select.test.tsx (2)
10-10: The update to theItemtype fromvaluetoidaligns with the PR's objectives and correctly reflects the new implementation in tests.
14-26: The adjustments in the test cases reflect the updatedItemtype and correctly handle keys, ensuring that the tests align with the new implementation of theSelectcomponent.Also applies to: 60-62, 74-76, 85-85, 96-100, 139-141, 172-174, 209-211, 257-259, 293-295, 334-336, 350-388
| "@nextui-org/use-aria-multiselect": patch | ||
| --- | ||
|
|
||
| Fix onSelectionChange can handle number (#2926) |
There was a problem hiding this comment.
Correct the typographical error in the description.
- Fix onSelectionChange can handle number (#2926)
+ Fix: onSelectionChange can handle number (#2926)Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| Fix onSelectionChange can handle number (#2926) | |
| Fix: onSelectionChange can handle number (#2926) |
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (7)
- .changeset/great-singers-repeat.md (1 hunks)
- packages/components/autocomplete/src/autocomplete.tsx (1 hunks)
- packages/components/dropdown/src/dropdown-menu.tsx (1 hunks)
- packages/components/listbox/src/listbox.tsx (1 hunks)
- packages/components/menu/src/menu.tsx (1 hunks)
- packages/components/select/src/select.tsx (2 hunks)
- packages/components/tabs/src/tabs.tsx (1 hunks)
Files skipped from review due to trivial changes (1)
- .changeset/great-singers-repeat.md
Files skipped from review as they are similar to previous changes (1)
- packages/components/select/src/select.tsx
Additional comments not posted (10)
packages/components/dropdown/src/dropdown-menu.tsx (2)
23-23: Ensure the type definition aligns with the expected usage ofDropdownMenuProps.
26-26: Verify that the type casting forforwardRefas a generic function is correctly implemented.packages/components/menu/src/menu.tsx (2)
74-74: Ensure the type definition aligns with the expected usage ofMenuProps.
77-77: Verify that the type casting forforwardRefas a generic function is correctly implemented.Verification successful
The type casting for
forwardRefas a generic function inMenuis correctly implemented and consistent with similar patterns found in other components within the codebase. Here are the locations where similar usage is observed:
packages/components/tabs/src/tabs.tsxpackages/components/select/src/select.tsxpackages/components/dropdown/src/dropdown-menu.tsxpackages/components/menu/src/menu.tsxpackages/components/listbox/src/listbox.tsxpackages/components/autocomplete/src/autocomplete.tsxScripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the correct implementation of type casting for `forwardRef` in `Menu`. # Test: Search for similar patterns in the codebase. Expect: Consistent usage of type casting. rg --type typescript $'forwardRef\($_\) as <T extends object>'Length of output: 98
Script:
#!/bin/bash # Description: Verify the correct implementation of type casting for `forwardRef` in `Menu`. # Correcting the file type to 'ts' for TypeScript and refining the regex pattern. rg --type ts 'forwardRef\([^)]+\) as <T extends object>' -g '*.tsx'Length of output: 840
packages/components/tabs/src/tabs.tsx (2)
60-60: Ensure the type definition aligns with the expected usage ofTabsProps.
63-63: Verify that the type casting forforwardRefas a generic function is correctly implemented.packages/components/listbox/src/listbox.tsx (2)
79-79: Ensure the type definition aligns with the expected usage ofListboxProps.
82-82: Verify that the type casting forforwardRefas a generic function is correctly implemented.packages/components/autocomplete/src/autocomplete.tsx (2)
61-61: Ensure the type definition aligns with the expected usage ofAutocompleteProps.
64-64: Verify that the type casting forforwardRefas a generic function is correctly implemented.
ryo-manba
changed the title
Closes #2926
📝 Description
Fixed an issue where specifying a
numberas thekeyforSelectItemresulted inonSelectionChangetreating it as astring.⛳️ Current behavior (updates)
When a
numberis specified as thekeyforSelectItem, astringis passed toonSelectionChange.🚀 New behavior
Now, when a
numberis specified as thekeyforSelectItem,onSelectionChangewill receive it as anumber.💣 Is this a breaking change (Yes/No):
No.
📝 Additional Information
This issue stems from React converting the key to a string.
See: https://react-spectrum.adobe.com/react-stately/collections.html#unique-keys
Summary by CodeRabbit
New Features
Bug Fixes
Documentation
Refactor