fix(table): table-column align prop #2900

chirokas · 2024-04-28T05:25:05Z

Closes #2886

📝 Description

TableColumn align prop fix.

⛳️ Current behavior (updates)

Missing align styles.

🚀 New behavior

Styles Fixed.

💣 Is this a breaking change (Yes/No):

📝 Additional Information

Summary by CodeRabbit

Bug Fixes
- Fixed alignment properties for table columns.
Style
- Improved text alignment options for table headers, including left, center, and right alignments.

changeset-bot · 2024-04-28T05:25:08Z

🦋 Changeset detected

Latest commit: 1914492

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@nextui-org/table	Patch
@nextui-org/theme	Patch
@nextui-org/react	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2024-04-28T05:25:09Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
nextui-storybook-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 16, 2024 1:56pm

vercel · 2024-04-28T05:25:10Z

@chirokas is attempting to deploy a commit to the NextUI Inc Team on Vercel.

A member of the Team first needs to authorize it.

coderabbitai · 2024-04-28T05:25:15Z

Walkthrough

The recent changes aim to address the issue of the malfunctioning align property in the TableColumn component by refining prop handling and enhancing alignment styles in the theme configurations. These modifications ensure the correct alignment of table headers based on the specified settings.

Changes

File Path	Change Summary
`.changeset/rich-sloths-jam.md`	Introduced patches for `@nextui-org/table` and `@nextui-org/theme` packages, fixing the `TableColumn align` prop and enhancing styles.
`.../table/src/table-cell.tsx`	Added `TableColumnProps` import, extracted properties using `columnProps`, and updated `className` assignment in `TableCell` for handling `align`.
`.../table/src/table-column-header.tsx`	Modified property destructuring in `TableColumnHeader` to include `align` alongside `hideHeader`, impacting class assignment in component rendering logic.
`.../core/theme/src/components/table.ts`	Restructured alignment properties for table elements, introduced specific settings for `start`, `center`, `end`, and added the `disableAnimation` property.

Assessment against linked issues

Objective	Addressed	Explanation
[BUG] - TableColumn Props.align does not work	✅	The adjustments made in prop handling and theme styles directly resolve the issue where `align` was not functioning as expected.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 1

coderabbitai · 2024-04-28T05:29:36Z

.changeset/rich-sloths-jam.md

+"@nextui-org/theme": patch
+---
+
+Fix #2886 TableColumn align prop fixed, style improved.


Correct the spelling mistake in the changeset description.

- Fix #2886 TableColumn align prop fixed, style improved. + Fix #2886: TableColumn align prop fixed; style improved.

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change

Fix #2886 TableColumn align prop fixed, style improved.

Fix #2886: TableColumn align prop fixed; style improved.

wingkwong

I think if the column is set with align, the table cells under this column should be set with the same align too.

coderabbitai

Actionable comments posted: 0

Review Details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between fc3a150 and 907fb33.

Files selected for processing (4)

.changeset/rich-sloths-jam.md (1 hunks)
packages/components/table/src/table-cell.tsx (3 hunks)
packages/components/table/src/table-column-header.tsx (2 hunks)
packages/core/theme/src/components/table.ts (3 hunks)

Files skipped from review due to trivial changes (1)

.changeset/rich-sloths-jam.md

Additional comments not posted (7)

packages/components/table/src/table-cell.tsx (3)

2-2: Importing TableColumnProps is necessary for type safety and clarity. Good addition!

53-54: Extracting columnProps from node.column?.props ensures that the align property is correctly utilized. This is a good practice for maintaining clean and modular code.

68-68: Incorporating the align property into the className assignment ensures that the alignment styles are applied correctly. This change addresses the issue effectively.

packages/components/table/src/table-column-header.tsx (2)

40-40: Extracting the align property from node.props ensures that the alignment styles are correctly applied to the table column header. This is a good practice for maintaining clean and modular code.

60-60: Incorporating the align property into the className assignment ensures that the alignment styles are applied correctly to the table column header. This change addresses the issue effectively.

packages/core/theme/src/components/table.ts (2)

250-263: Adding the align property with specific settings for start, center, and end enhances the flexibility and customization of table alignment within the NextUI framework. This is a well-implemented change.

274-275: Setting the default value for align to "start" ensures that the table alignment has a consistent default behavior. This is a good practice for maintaining predictable and user-friendly defaults.

coderabbitai

Actionable comments posted: 0

Review Details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 907fb33 and 1914492.

Files selected for processing (4)

.changeset/rich-sloths-jam.md (1 hunks)
packages/components/table/src/table-cell.tsx (3 hunks)
packages/components/table/src/table-column-header.tsx (2 hunks)
packages/core/theme/src/components/table.ts (3 hunks)

Files skipped from review as they are similar to previous changes (4)

.changeset/rich-sloths-jam.md
packages/components/table/src/table-cell.tsx
packages/components/table/src/table-column-header.tsx
packages/core/theme/src/components/table.ts

chirokas requested a review from jrgarciadev as a code owner April 28, 2024 05:25

vercel bot deployed to Preview – nextui-storybook-v2 April 28, 2024 05:27 View deployment

coderabbitai bot reviewed Apr 28, 2024

View reviewed changes

wingkwong changed the base branch from main to canary April 28, 2024 14:42

chirokas changed the title ~~fix(table): tablecolumn align prop~~ fix(table): table-column align prop May 7, 2024

wingkwong self-assigned this May 10, 2024

wingkwong added this to the v2.3.7 milestone May 15, 2024

wingkwong reviewed May 16, 2024

View reviewed changes

wingkwong removed their assignment May 16, 2024

chirokas force-pushed the fix/2886 branch from fc3a150 to 907fb33 Compare May 16, 2024 13:46

vercel bot deployed to Preview – nextui-storybook-v2 May 16, 2024 13:49 View deployment

coderabbitai bot reviewed May 16, 2024

View reviewed changes

fix(table): table-column align prop

1914492

chirokas force-pushed the fix/2886 branch from 907fb33 to 1914492 Compare May 16, 2024 13:53

vercel bot deployed to Preview – nextui-storybook-v2 May 16, 2024 13:56 View deployment

coderabbitai bot reviewed May 16, 2024

View reviewed changes

chirokas requested a review from wingkwong May 16, 2024 14:07

wingkwong self-assigned this May 16, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(table): table-column align prop #2900

fix(table): table-column align prop #2900

chirokas commented Apr 28, 2024 •

edited by coderabbitai bot

changeset-bot bot commented Apr 28, 2024 •

edited

vercel bot commented Apr 28, 2024 •

edited

vercel bot commented Apr 28, 2024

coderabbitai bot commented Apr 28, 2024 •

edited

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

coderabbitai bot left a comment

coderabbitai bot Apr 28, 2024

wingkwong left a comment

coderabbitai bot left a comment

coderabbitai bot left a comment

	Fix #2886 TableColumn align prop fixed, style improved.
	Fix #2886: TableColumn align prop fixed; style improved.

fix(table): table-column align prop #2900

Are you sure you want to change the base?

fix(table): table-column align prop #2900

Conversation

chirokas commented Apr 28, 2024 • edited by coderabbitai bot

📝 Description

⛳️ Current behavior (updates)

🚀 New behavior

💣 Is this a breaking change (Yes/No):

📝 Additional Information

Summary by CodeRabbit

changeset-bot bot commented Apr 28, 2024 • edited

🦋 Changeset detected

vercel bot commented Apr 28, 2024 • edited

vercel bot commented Apr 28, 2024

coderabbitai bot commented Apr 28, 2024 • edited

Walkthrough

Changes

Assessment against linked issues

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot Apr 28, 2024

Choose a reason for hiding this comment

wingkwong left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

chirokas commented Apr 28, 2024 •

edited by coderabbitai bot

changeset-bot bot commented Apr 28, 2024 •

edited

vercel bot commented Apr 28, 2024 •

edited

coderabbitai bot commented Apr 28, 2024 •

edited

CodeRabbit Configration File (`.coderabbit.yaml`)