Fix DatePicker Time Input #2845

chirokas · 2024-04-22T15:48:00Z

Closes #

📝 Description

Closing the Date Picker while the Month and Year Pickers are open causes the Time Input to disappear when reopened.

nextui/packages/components/date-picker/src/date-picker.tsx

Lines 41 to 42 in 1ba2d02

 const calendarBottomContent = useMemo(() => { 

 if (isCalendarHeaderExpanded) return null;

⛳️ Current behavior (updates)

20240424_160529.mp4

20240422_221921.mp4

Please describe the current behavior that you are modifying

🚀 New behavior

20240422_221611.mp4

Please describe the behavior or changes this PR adds

💣 Is this a breaking change (Yes/No):

📝 Additional Information

Summary by CodeRabbit

New Features
- Enhanced the date picker with improved functionalities:
  - Automatic closure of the calendar header when the date picker is closed.
  - Improved control flow with an onOpenChange callback to manage open state changes.
- Implemented tests for Month and Year Picker functionality in the DatePicker component.

changeset-bot · 2024-04-22T15:48:03Z

🦋 Changeset detected

Latest commit: c67c283

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@nextui-org/date-picker	Patch
@nextui-org/react	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2024-04-22T15:48:04Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
nextui-storybook-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 16, 2024 8:31am

vercel · 2024-04-22T15:48:05Z

@chirokas is attempting to deploy a commit to the NextUI Inc Team on Vercel.

A member of the Team first needs to authorize it.

coderabbitai · 2024-04-22T15:48:07Z

Walkthrough

The recent updates to the date picker component focus on improving control over open and close states. The onOpenChange callback enhances state management, while the new onClose function ensures the calendar header collapses correctly when the date picker closes, thus enhancing the user experience.

Changes

File Path	Change Summary
`.../date-picker/src/use-date-picker-base.ts`	Replaced `useState` with `useCallback`, updated state handling, added `onClose` function.
`.../date-picker/src/use-date-picker.ts`	Added `onOpenChange` callback to manage open state changes.
`.../date-picker/__tests__/date-picker.test.tsx`	Introduced tests for Month and Year Picker functionality in `DatePicker`.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

wingkwong

please add some description on the issue and what you are trying to fix
please add a changeset since you've changed the src code
please add tests to cover the logic you added

wingkwong

please add tests to packages/components/date-picker/__tests__/date-picker.test.tsx to cover the logic you added.

…Picker is closed

coderabbitai

Actionable comments posted: 1

.changeset/pretty-crews-build.md

wingkwong

The test cases you added just cover the base case of month and year picker, which is ok. However, I didn't see the logic where the PR is trying to solve in the test case, i.e. calendarBottomContent should be still here after open the month / year picker and the date picker.

chirokas · 2024-05-07T06:44:54Z

If there are any problems, please guide me. Thanks!

packages/components/date-picker/__tests__/date-picker.test.tsx

coderabbitai

Actionable comments posted: 0

Review Details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 2e8dafe and c6a40b5.

Files selected for processing (1)

packages/components/date-picker/tests/date-picker.test.tsx (1 hunks)

Files not reviewed due to errors (1)

packages/components/date-picker/tests/date-picker.test.tsx (no review received)

coderabbitai

Actionable comments posted: 0

Review Details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between c6a40b5 and c67c283.

Files selected for processing (1)

packages/components/date-picker/src/use-date-picker-base.ts (6 hunks)

Files not reviewed due to errors (1)

packages/components/date-picker/src/use-date-picker-base.ts (no review received)

chirokas requested a review from jrgarciadev as a code owner April 22, 2024 15:48

vercel bot deployed to Preview – nextui-storybook-v2 April 22, 2024 15:50 View deployment

wingkwong requested changes Apr 22, 2024

View reviewed changes

wingkwong added the 🚧 Status: Changes Requested label Apr 22, 2024

kuri-sun added the 🏌️ Status: Action Needed label Apr 23, 2024

vercel bot deployed to Preview – nextui-storybook-v2 April 24, 2024 08:51 View deployment

chirokas requested a review from wingkwong April 26, 2024 06:57

wingkwong requested changes Apr 26, 2024

View reviewed changes

chirokas added 2 commits April 26, 2024 23:47

fix(date-picker): set isCalendarHeaderExpanded to false when Date…

dbc8658

…Picker is closed

fix(date-picker): calendar header controlled state on DatePicker

e7cf05d

chirokas force-pushed the fix/date-picker branch from b02ebef to e7cf05d Compare April 26, 2024 16:11

vercel bot deployed to Preview – nextui-storybook-v2 April 26, 2024 16:14 View deployment

coderabbitai bot reviewed Apr 26, 2024

View reviewed changes

.changeset/pretty-crews-build.md Show resolved Hide resolved

chirokas requested a review from wingkwong April 26, 2024 16:16

wingkwong changed the base branch from main to canary April 28, 2024 14:46

wingkwong self-assigned this Apr 28, 2024

wingkwong removed 🚧 Status: Changes Requested 🏌️ Status: Action Needed labels Apr 28, 2024

wingkwong requested changes Apr 29, 2024

View reviewed changes

wingkwong assigned chirokas and unassigned wingkwong Apr 29, 2024

wingkwong added the 🚧 Status: Changes Requested label Apr 29, 2024

chore(date-picker): update test

2e8dafe

vercel bot deployed to Preview – nextui-storybook-v2 April 29, 2024 08:52 View deployment

chirokas requested a review from wingkwong April 29, 2024 08:55

chirokas removed their assignment May 1, 2024

wingkwong removed the 🚧 Status: Changes Requested label May 7, 2024

wingkwong self-assigned this May 7, 2024

wingkwong reviewed May 9, 2024

View reviewed changes

packages/components/date-picker/__tests__/date-picker.test.tsx Outdated Show resolved Hide resolved

chore(date-picker): remove unnecessary async in test

c6a40b5

vercel bot deployed to Preview – nextui-storybook-v2 May 9, 2024 12:17 View deployment

coderabbitai bot reviewed May 9, 2024

View reviewed changes

chirokas requested a review from wingkwong May 9, 2024 12:20

Merge branch 'canary' into pr/2845

c67c283

vercel bot deployed to Preview – nextui-storybook-v2 May 16, 2024 08:31 View deployment

coderabbitai bot reviewed May 16, 2024

View reviewed changes

wingkwong approved these changes May 16, 2024

View reviewed changes

wingkwong assigned jrgarciadev and unassigned wingkwong May 16, 2024

wingkwong added this to the v2.3.7 milestone May 16, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix DatePicker Time Input #2845

Fix DatePicker Time Input #2845

chirokas commented Apr 22, 2024 •

edited by coderabbitai bot

changeset-bot bot commented Apr 22, 2024 •

edited

vercel bot commented Apr 22, 2024 •

edited

vercel bot commented Apr 22, 2024

coderabbitai bot commented Apr 22, 2024 •

edited

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

wingkwong left a comment

wingkwong left a comment

coderabbitai bot left a comment

wingkwong left a comment

chirokas commented May 7, 2024

coderabbitai bot left a comment

coderabbitai bot left a comment

	const calendarBottomContent = useMemo(() => {
	if (isCalendarHeaderExpanded) return null;

Fix DatePicker Time Input #2845

Are you sure you want to change the base?

Fix DatePicker Time Input #2845

Conversation

chirokas commented Apr 22, 2024 • edited by coderabbitai bot

📝 Description

⛳️ Current behavior (updates)

🚀 New behavior

💣 Is this a breaking change (Yes/No):

📝 Additional Information

Summary by CodeRabbit

changeset-bot bot commented Apr 22, 2024 • edited

🦋 Changeset detected

vercel bot commented Apr 22, 2024 • edited

vercel bot commented Apr 22, 2024

coderabbitai bot commented Apr 22, 2024 • edited

Walkthrough

Changes

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

wingkwong left a comment

Choose a reason for hiding this comment

wingkwong left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

wingkwong left a comment

Choose a reason for hiding this comment

chirokas commented May 7, 2024

coderabbitai bot left a comment

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

chirokas commented Apr 22, 2024 •

edited by coderabbitai bot

changeset-bot bot commented Apr 22, 2024 •

edited

vercel bot commented Apr 22, 2024 •

edited

coderabbitai bot commented Apr 22, 2024 •

edited

CodeRabbit Configration File (`.coderabbit.yaml`)