Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(components): error in selecting all #2329

Conversation

kuri-sun
Copy link
Member

@kuri-sun kuri-sun commented Feb 10, 2024

Closes #2313

📝 Description

When I select all in the table with 100 data(10 rows per page), go to the next page and uncheck one of the rows.
It says "9 items are selected", however, it should say "99" not "9".

https://nextui.org/docs/components/table

⛳️ Current behavior (old)

prev.mov

🚀 New behavior

new.mov
  • When users select the "All" checkbox select all rows in the current table instead of selecting all rows table throughout the pages.

💣 Is this a breaking change (Yes/No):

No, Never touched the table component itself.

📝 Additional Information

No.

Copy link

changeset-bot bot commented Feb 10, 2024

⚠️ No Changeset found

Latest commit: ec8b4d2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Feb 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextui-storybook-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2024 6:43am

Copy link

vercel bot commented Feb 10, 2024

@kuri-sun is attempting to deploy a commit to the NextUI Team on Vercel.

A member of the Team first needs to authorize it.

@jrgarciadev
Copy link
Member

Hi @kuri-sun,

Thank you for submitting this pull request. Could we consider adjusting the functionality slightly? I believe the intended behavior is to select all rows initially and then allow the user to deselect specific ones. For an example of this implementation, please refer to the row selection example here: TanStack Table Row Selection.

@kuri-sun
Copy link
Member Author

kuri-sun commented Feb 13, 2024

@jrgarciadev I found a way to achieve the requirement. I will update the PR. Thank you! 😄

@kuri-sun
Copy link
Member Author

@jrgarciadev, Here is the new behavior!✌️ I would like you to let me know that this behavior meets the requirements. Thank you! 😄

  • By selecting all rows initially and then allowing the user to deselect specific rows.
new.mov

@kuri-sun kuri-sun self-assigned this Apr 13, 2024
@kuri-sun kuri-sun closed this by deleting the head repository Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - error in selecting all
2 participants