Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include profile for open 21L builds #1101

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Include profile for open 21L builds #1101

wants to merge 3 commits into from

Conversation

trvrb
Copy link
Member

@trvrb trvrb commented Mar 9, 2024

Description of proposed changes

This PR copies the logic in nextstrain_profiles/nextstrain-gisaid-21L/ to /nextstrain_profiles/nextstrain-open-21L/. Specific gisaid vs open changes etc... were derived by diffing the existing nextstrain-gisaid vs the existing nextstrain-open profiles.

Testing

I've copied the existing rebuild-gisaid-21L.yml GitHub Action to rebuild-open-21L.yml. However, I don't know how to run this as a test while this file is still on the branch open-21L instead of master. Any advice here?

Release checklist

  • Update docs/src/reference/change_log.md in this pull request to document these changes by the date they were added.

This commit completely copies the logic in nextstrain_profiles/nextstrain-gisaid-21L/ to /nextstrain_profiles/nextstrain-open-21L/. Specific gisaid vs open changes etc... were derived by diffing the existing nextstrain-gisaid vs the existing nextstrain-open profiles.

In addition, this commit:
1. Fixes reference traits and frequencies for nextstrain-gisaid-21L
2. Switches from Nextstrain_clade, eg "21H (Mu)", to clade_nextstrain, eg "21H" during prefilter.
@trvrb trvrb requested a review from a team March 9, 2024 23:33
@joverlee521
Copy link
Contributor

However, I don't know how to run this as a test while this file is still on the branch open-21L instead of master. Any advice here?

I'm usually using Tom's work-around for testing GitHub Action workflows that are not on the default branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants