Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] correct errors on /unsplash/templates/settings/admin.php and improvement pt_BR translate #127

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

leolemos
Copy link

@leolemos leolemos commented Aug 19, 2023

fixed error when accessing app settings
"message":"include(): Failed opening .../partials/license.php'

correct pt_BR.json and pt_BR.js

create file js/user.js to prevent error when access user theme edit panel

commented out line 10 from file /templates/settings/personal.php
preventing error when accessing the user's theme settings

fixed error when accessing app settings
"message":"include(): Failed opening .../partials/license.php'

Signed-off-by: Leonardo Lemos <[email protected]>
Signed-off-by: Leonardo Lemos <[email protected]>
Signed-off-by: Leonardo Lemos <[email protected]>
@leolemos leolemos changed the title correct error on /unsplash/templates/settings/admin.php correct errors on /unsplash/templates/settings/admin.php and improvement pt_BR translate Aug 19, 2023
Signed-off-by: Leonardo Lemos <[email protected]>
Signed-off-by: Leonardo Lemos <[email protected]>
Signed-off-by: Leonardo Lemos <[email protected]>
commented out line 10
script('unsplash', 'user');
preventing error when accessing the user's theme settings

Signed-off-by: Leonardo Lemos <[email protected]>
@newhinton newhinton changed the title correct errors on /unsplash/templates/settings/admin.php and improvement pt_BR translate [WIP] correct errors on /unsplash/templates/settings/admin.php and improvement pt_BR translate Aug 19, 2023
@newhinton
Copy link
Contributor

Can you mark this as done when it is ready to review? Thanks!

@leolemos
Copy link
Author

Can you mark this as done when it is ready to review? Thanks!

hello :-)

could you help me to mark as done?

sorry but this is my 1st time using github and I don't know how to do this :-(

thanks :-)

@newhinton
Copy link
Contributor

Can you mark this as done when it is ready to review? Thanks!

hello :-)

could you help me to mark as done?

sorry but this is my 1st time using github and I don't know how to do this :-(

thanks :-)

Sure! I just added a [WIP] to the title of this PR. However, the right way to do it is to use the draft-function, but i didn't do that.

So the next time you create a PR and want to indicate that you are not done, you can click on that:
grafik

Its on the top right of this page. However, i fixed it for you.

Now to your actual PR:
Frist, thanks for contributing! It is always good to see people wanting to chime in!

It seems you did two things:

  1. Updatin translations
  2. Fixing a loading issue with some partials.

Usually it is a good idea to split RP's into multiple ones if you fix different issues. Here one with the translations would be good, and another one with the fixes for the partials. However, since this is a small PR and it's your first time, i will review it how it is and merge it if i cant find anything that needs change. From a first glance it looks good, but i will need to verify the code and i cant to that at the moment. (Worst case i will do it at the upcoming nextcloud conference in a few weeks!)

Welcome to open source!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants