Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sidebar): use open state to remove always working focus trap on mobile #12387

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented May 17, 2024

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
Screenshot before Screenshot after

🚧 Tasks

  • ...

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • 🖥️ Tested with Desktop client or should not be risky for it
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@ShGKme ShGKme added this to the 💙 Next Major (30) milestone May 17, 2024
@ShGKme ShGKme self-assigned this May 17, 2024
@ShGKme ShGKme changed the title fix(sidebar): use open state to remove always working focus trap fix(sidebar): use open state to remove always working focus trap with @nextcloud/[email protected] Jun 13, 2024
@ShGKme ShGKme changed the title fix(sidebar): use open state to remove always working focus trap with @nextcloud/[email protected] fix(sidebar): use open state to remove always working focus trap on mobile with @nextcloud/[email protected] Jun 13, 2024
@ShGKme ShGKme changed the title fix(sidebar): use open state to remove always working focus trap on mobile with @nextcloud/[email protected] fix(sidebar): use open state to remove always working focus trap on mobile Jun 13, 2024
@ShGKme ShGKme added the dependencies Pull requests that update a dependency file label Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing bug dependencies Pull requests that update a dependency file feature: frontend 🖌️ "Web UI" client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't select message text box
1 participant