Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(mobile): use button without text if on mobile #12383

Merged
merged 1 commit into from
May 21, 2024
Merged

feat(mobile): use button without text if on mobile #12383

merged 1 commit into from
May 21, 2024

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented May 17, 2024 •
edited

For #10358

Before After
image image
For my own testing 
docker run -it --rm ^
--name nextcloud-easy-test1 ^
-p 8443:443 ^
-e TALK_BRANCH=enh/noid/shrink-button ^
--volume="nextcloud_easy_test_npm_cache_volume:/var/www/.npm" ^
ghcr.io/szaimen/nextcloud-easy-test:latest

@szaimen szaimen added this to the 💙 Next Major (30) milestone May 17, 2024
@szaimen szaimen marked this pull request as ready for review May 17, 2024 08:23
Antreesy
Antreesy reviewed May 17, 2024
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest is good, IMO. Let's wait for other's feedback

src/components/TopBar/CallButton.vue Outdated Show resolved Hide resolved
@szaimen szaimen requested review from ShGKme and Antreesy May 17, 2024 13:15
nimishavijay
nimishavijay approved these changes May 18, 2024
View reviewed changes
Copy link
Member

@nimishavijay nimishavijay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@szaimen
Copy link
Contributor Author

szaimen commented May 21, 2024

Merge?

DorraJaouad
DorraJaouad approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@szaimen szaimen enabled auto-merge May 21, 2024 11:43
@szaimen szaimen merged commit 0776c67 into main May 21, 2024
46 checks passed
@szaimen szaimen deleted the enh/noid/shrink-button branch May 21, 2024 11:52
@Antreesy Antreesy mentioned this pull request May 31, 2024
Merged
5 tasks
@Antreesy
Copy link
Contributor

Antreesy commented Jun 7, 2024

/backport to stable29

@backportbot backportbot bot mentioned this pull request Jun 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoambrosini marcoambrosini marcoambrosini approved these changes

@nimishavijay nimishavijay nimishavijay approved these changes

@DorraJaouad DorraJaouad DorraJaouad approved these changes

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@ShGKme ShGKme Awaiting requested review from ShGKme

@Antreesy Antreesy Awaiting requested review from Antreesy

Assignees
No one assigned
Labels
3. to review browser: Mobile View design enhancement
Projects
None yet
Milestone
💙 Next Major (30)
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@szaimen @Antreesy @ShGKme @marcoambrosini @nimishavijay @DorraJaouad