Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Switch to PlayWright for E2E and component tests #2077

Merged
merged 2 commits into from
Jun 13, 2024

Conversation

susnux
Copy link
Collaborator

@susnux susnux commented Apr 16, 2024

This should be more stable than Cypress + real open source and not open core...
Also this is faster.

I will add more tests later.

@susnux susnux added the 2. developing Work in progress label Apr 16, 2024
@susnux susnux force-pushed the feat/playwright branch 2 times, most recently from 2aacdb5 to 71c9e0c Compare June 12, 2024 21:59
@susnux susnux marked this pull request as ready for review June 12, 2024 22:04
@susnux susnux added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jun 12, 2024
@susnux susnux requested a review from Chartman123 June 12, 2024 22:06
@Chartman123
Copy link
Collaborator

@susnux could you please remove the last commit? Then we can merge this one as well :)

Page object models allow to write tests independent of locators,
this allows for easier maintenance in case locators change.

Signed-off-by: Ferdinand Thiessen <[email protected]>
@Chartman123 Chartman123 merged commit a77de95 into main Jun 13, 2024
51 checks passed
@Chartman123 Chartman123 deleted the feat/playwright branch June 13, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants