Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(admin): Revise opcache revalidation tuning section #11872

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

joshtrichards
Copy link
Member

@joshtrichards joshtrichards commented May 28, 2024

☑️ Resolves

  • Try to make PHP revalidation values, suggestions, and trade-offs more apparent (main focus of this PR)
  • Add big warnings about impact of lengthening frequency of revalidations and/or disabling outright
  • Try to make the opcache tuning section a bit more organized (move things around more logically, add sub-headings)

Also, related to pending enhancement: nextcloud/server#45498

Note: The main thing that is perhaps controversial here is the PHP default of 2 versus 60 (not so much because we ever formally recommended changing it to 60, but because 60 is already being used in both the AIO and micro-services/community Docker image). I'm of the camp that PHP's default of 2 should be emphasized. And any deviation from that is fine, but the operator making that change is on their own (and expected to restart/etc if needed). Fortunately with the Docker images (at least ours), at least for Server itself, it's less of an issue since the code upgrades only happen through a container restart (but still a factor for config.php + potentially for app updates).

Historical (most relevant):

🖼️ Screenshots

image

@joshtrichards
Copy link
Member Author

/backport to stable29

@joshtrichards
Copy link
Member Author

/backport to stable28

@joshtrichards
Copy link
Member Author

/backport to stable27

@joshtrichards joshtrichards requested a review from J0WI May 28, 2024 14:39
@@ -146,9 +164,30 @@ To disable the revalidation completely:

opcache.validate_timestamps = 0

Any change to ``config.php`` will then require either restarting PHP, manually clearing the cache, or invalidating this particular script.
Any Server/app upgrades or changes to ``config.php`` will then require restarting PHP (or otherwise manually clearing the cache or invalidating this particular script).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any server or app upgrade done from within the web interface triggers an OPcache reset. Only upgrades done via occ require a manual cache reset or PHP restart, if revalidation is disabled.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Any Server/app upgrades or changes to ``config.php`` will then require restarting PHP (or otherwise manually clearing the cache or invalidating this particular script).
Any Server/app upgrades via ``occ`` command or changes to ``config.php`` will then require restarting PHP (or otherwise manually clearing the cache or invalidating this particular script).

@kesselb
Copy link
Contributor

kesselb commented May 28, 2024

Thanks 👍

I thought about removing validate_timestamp because it appears that many people do not understand the implications.

Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants