Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect date parsing. #6738

Merged
merged 1 commit into from
May 19, 2024
Merged

Conversation

allexzander
Copy link
Contributor

No description provided.

@allexzander
Copy link
Contributor Author

This fails to parse when built with Qt6, the assert gets triggered. I applied the same change as in here https://github.com/nextcloud/desktop/blob/master/src/libsync/discoveryphase.cpp#L470

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6738-00022a3f9c803d91ae448aeaf3198153e01838f6-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

Copy link

sonarcloud bot commented May 7, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
D Maintainability Rating on New Code (required ≥ A)
2 New Code Smells (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@allexzander allexzander merged commit f1c37d7 into master May 19, 2024
8 of 13 checks passed
@allexzander allexzander deleted the bugfix/incorrect-date-parsing branch May 19, 2024 20:57
@allexzander
Copy link
Contributor Author

/backport to stable-3.13

Copy link

backportbot bot commented May 19, 2024

The backport to stable-3.13 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable-3.13
git pull origin stable-3.13

# Create the new backport branch
git checkout -b backport/6738/stable-3.13

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 00022a3f

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/6738/stable-3.13

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants