Bugfix/fix vfs folder state when remote move is forbidden #6717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgallien
force-pushed
the
bugfix/fixVfsFolderStateWhenRemoteMoveIsForbidden
branch
from
d1aef86
to
7275b8a
Compare
claucambra
requested changes
May 4, 2024
mgallien
force-pushed
the
bugfix/fixVfsFolderStateWhenRemoteMoveIsForbidden
branch
from
7275b8a
to
b058995
Compare
mgallien
force-pushed
the
bugfix/fixVfsFolderStateWhenRemoteMoveIsForbidden
branch
from
b058995
to
c9d76f7
Compare
when remote move is forbidden, desktop client will move back the folder to its original name in such cases, we were forgetting to set VFS metadata in their proper state (i.e. placeholder in sync) so ensure that when a remote move fails, we still touch VFS metadata when appropriate and handle errors Signed-off-by: Matthieu Gallien <[email protected]>
when doing local discovery, it is possible that files or folders may be discovered with VFS metadata not up to date (i.e. placeholder file not set in sync) in such case, generate a propagation instruction to set them in sync Signed-off-by: Matthieu Gallien <[email protected]>
mgallien
force-pushed
the
bugfix/fixVfsFolderStateWhenRemoteMoveIsForbidden
branch
from
c9d76f7
to
9202dfd
Compare
|
|
AppImage file: nextcloud-PR-6717-9202dfd84d2c221bf47256d92707046dd34d7d26-x86_64.AppImage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.