Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use application name instead of domain as app identifier. #6518

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

camilasan
Copy link
Member

@camilasan camilasan commented Mar 7, 2024

To make sure the user do not see the name Nextcloud when the client is branded.

@camilasan camilasan force-pushed the bugfix/login-items-notification branch from 7e6732e to a46988b Compare March 7, 2024 12:18
@camilasan camilasan changed the title Use application name instead of domain as app identifier. WIP: Use application name instead of domain as app identifier. Mar 7, 2024
Copy link

sonarcloud bot commented Mar 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@camilasan camilasan force-pushed the bugfix/login-items-notification branch from a46988b to 0463888 Compare April 15, 2024 20:30
@camilasan camilasan changed the title WIP: Use application name instead of domain as app identifier. Use application name instead of domain as app identifier. Apr 15, 2024
@camilasan camilasan marked this pull request as ready for review April 15, 2024 20:32
@camilasan
Copy link
Member Author

/backport to stable-3.12

@camilasan
Copy link
Member Author

/backport to stable-3.13

Copy link
Collaborator

@claucambra claucambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick

src/common/utility_mac.mm Outdated Show resolved Hide resolved
src/common/utility_mac.mm Outdated Show resolved Hide resolved
To make sure the user do not see the name Nextcloud when the client is branded.

Signed-off-by: Camila Ayres <[email protected]>
@camilasan camilasan force-pushed the bugfix/login-items-notification branch from 0463888 to bb9cc8b Compare May 15, 2024 12:41
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6518-bb9cc8bbfbdd37eaf0b99c12b88bf7c746493b07-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

Copy link

sonarcloud bot commented May 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@camilasan
Copy link
Member Author

❗ TO DO before merging:

  • test this change with file providers

Copy link
Collaborator

@claucambra claucambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@camilasan did you have a chance to test yet? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants