added option for High DPI displays to enable and disable scaling #6274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to enable and disable scaling functionality on High DPI displays Signed-off-by: Yves Jeanrenaud <[email protected]>
Signed-off-by: Yves Jeanrenaud <[email protected]>
Signed-off-by: Yves Jeanrenaud <[email protected]>
Signed-off-by: Yves Jeanrenaud <[email protected]>
claucambra
requested changes
Dec 15, 2023
Comment on lines
+250
to
+252
| false | ||
| #endif | ||
| ; |
There was a problem hiding this comment.
Suggested change
| false | |
| #endif | |
| ; | |
| false; | |
| #endif |
| #else | ||
| QOperatingSystemVersion::current() >= QOperatingSystemVersion::Windows10; | ||
| #endif | ||
| //TODO need to check for platform windows:dpiawareness |
There was a problem hiding this comment.
Please implement this TODO
| #ifdef Q_OS_WIN | ||
| QCoreApplication::setAttribute(Qt::AA_EnableHighDpiScaling, true); | ||
| #endif // !Q_OS_WIN | ||
| if(_configFile->scaleForHighDPIDisplay->scale == true) { |
There was a problem hiding this comment.
Suggested change
| if(_configFile->scaleForHighDPIDisplay->scale == true) { | |
| if (_configFile->scaleForHighDPIDisplay->scale) { |
|
Could you also add a screenshot of the settings window with your changes? |
|
Would love to see it merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5373
So I added a checkbox to the settings and the corresponding code to handle that Qt function
Signed-off-by: Yves Jeanrenaud [email protected]