enh(debugArchive): Add reminder to redact before sharing #6238
Conversation
Closes #3189 Signed-off-by: Josh Richards <[email protected]>
|
AppImage file: nextcloud-PR-6238-00a13dd2424bbbcef8bdaa6cf39fdb4f3c27090f-x86_64.AppImage |
|
SonarCloud Quality Gate failed.
|
joshtrichards
added
2. to review
enhancement
| @@ -501,7 +501,7 @@ void GeneralSettings::slotCreateDebugArchive() | |||
| } | |||
|
|
|||
| createDebugArchive(filename); | |||
| QMessageBox::information(this, tr("Debug Archive Created"), tr("Debug archive is created at %1").arg(filename)); | |||
| QMessageBox::information(this, tr("Debug Archive Created"), tr("Redact information deemed sensitive before sharing! Debug archive created at %1").arg(filename)); | |||
There was a problem hiding this comment.
I think that what would be better is to warn that this may have sensitive data and people should be considerate before sharing (and may want to redact some info if needed)
I am pretty sure as an user I would be so afraid of sharing the debug archive once I would have read this text
if that means that the bug affecting me cannot be solved, then there is an lost opportunity
There was a problem hiding this comment.
I wonder if maybe we tackle this problem in two parts (aiming to achieve all three of: better bug reports + streamlining log request while triaging + increased comfort with providing logs to reduce lost opportunities) by doing something like:
- Add a README section that is about providing debug logs that encourages people to reproduce on a test account if they're hesitant (which will have less privacy concerns); also provides a convenient spot to direct people to on "how to get logs" (and where, if we so choose down the road, to add maybe a few key bits to search and replace out if one is concerned with sensitive details when they can't use a test account or whatever)
- Make the message in this PR softer (which I think is what you're proposing)
Closes #3189
Adds a reminder, when a debug archive is created, that information deemed sensitive should be redacted before sharing.