-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify Notifications #12907
Unify Notifications #12907
Conversation
46bf27c
to
32d0efb
Compare
fb239e5
to
248ee8a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general these changes seem to work and not break anything.
Please revert any changes made to app/src/main/res/values-*/strings.xml
as these files are managed via transifex.
app/src/main/java/com/nextcloud/client/jobs/upload/FileUploadWorker.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/nextcloud/client/jobs/upload/FileUploadWorker.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/nextcloud/client/jobs/upload/UploadNotificationManager.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/nextcloud/client/jobs/upload/UploadNotificationManager.kt
Show resolved
Hide resolved
Pull request was converted to draft
248ee8a
to
cf2f350
Compare
ddc2a78
to
ceac70c
Compare
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
…icationManager.kt Co-authored-by: Tom <[email protected]> Signed-off-by: Alper Öztürk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
…nting unnecessary updates Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
feb9d04
to
28bdc1d
Compare
Signed-off-by: alperozturk <[email protected]>
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12907.apk |
What does this PR?
Before
before.mp4
After
v.mp4
How to Test
Test one file download
Test one file upload
Test multiple file upload
Test multiple file download
Test all above scenarios for e2e