Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(examples): use correct http code in express config #10901

Merged
merged 2 commits into from
May 15, 2024

Conversation

uhidontkno
Copy link
Contributor

☕️ Reasoning

The wrong HTTP response code is being used.
Instead of HTTP 400 (Bad Request) use HTTP 401 (Unauthorized).



The other things in the pull request template have been removed as they are not applicable. It is a minor fix.

Copy link

vercel bot commented May 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2024 9:15am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview May 15, 2024 9:15am

Copy link

vercel bot commented May 14, 2024

@uhidontkno is attempting to deploy a commit to the authjs Team on Vercel.

A member of the Team first needs to authorize it.

@uhidontkno uhidontkno changed the title feat: use correct http code fix(examples): use correct http code May 14, 2024
Copy link
Member

@ndom91 ndom91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@ndom91 ndom91 changed the title fix(examples): use correct http code chore(examples): use correct http code May 15, 2024
@ndom91 ndom91 changed the title chore(examples): use correct http code chore(examples): use correct http code in express config May 15, 2024
@ndom91 ndom91 merged commit e723f4e into nextauthjs:main May 15, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants