-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(test): re-enable nextjs-docker tests #10863
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Ignored Deployments
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10863 +/- ##
=======================================
Coverage 37.51% 37.51%
=======================================
Files 173 173
Lines 26983 26983
Branches 1176 1176
=======================================
Hits 10122 10122
Misses 16861 16861 ☔ View full report in Codecov by Sentry. |
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat is an install script?Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts. Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
☕️ Reasoning
Run E2E tests (Nextjs-Docker)
testCredentials
provider, but we don't want it in the deployed example, so it has to be filtered out via Env var, for example.Run E2E tests
job (running playwright in the GHA container directly against the dev app in the container), seems to be stable and passing every timeTodo
For some reason, the example app in the container is throwing configuration errors when trying to visit
/auth/signin
directly (for example). Works fine locally (when built into a container).See example playwright trace.zip, which can be viewed at https://trace.playwright.dev
🧢 Checklist
🎫 Affected issues
📌 Resources