chore(docs): update middleware redirect example #10815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current example of protecting with Next.js middleware isn't functioning. I propose a new example that works correctly and is easy to understand.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
@DenilDenilson is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
ndom91
reviewed
May 6, 2024
ndom91
changed the title
|
Thanks for the cleanup! One small nit, but otherwise LGTM |
Co-authored-by: Nico Domino <[email protected]>
ndom91
approved these changes
May 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current example of protecting with Next.js middleware isn't functioning. I propose a new example that works correctly and is easy to understand.
☕️ Reasoning
In the documentation for protecting resources with Next.js middleware, the example code isn't functioning correctly. The 'replace' method replaces the first '/' in the URL (https://...) with 'loginlocalhost:/', which is an error. I've made changes to the code in the documentation to ensure it works properly by using the URL constructor with the base URL and the new pathname. Additionally, I've implemented a new validation to prevent infinite redirects.
🧢 Checklist
🎫 Affected issues
📌 Resources