Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add required phrase rules automatically #3254

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

Add required phrase rules automatically #3254

wants to merge 9 commits into from

Conversation

AyanSinhaMahapatra
Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra commented Feb 15, 2023 •
edited

Reference: #2637 #2878

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 馃搼 and links the original issue above 馃敆
  • Tests pass -- look for a green checkbox 鉁旓笍 a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 馃搧

@AyanSinhaMahapatra
Add script and functions for adding required phrases
9a995dd 
Add a script which can add required phrases in already existing rules
automatically from license field names, and can do this one license
expression at a time.

Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
@AyanSinhaMahapatra
Add required phrases for apache-2.0 rules
8cb1fe4 
These were added automatically by the script added at
etc/scripts/licenses/add_required_phrases.py

Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
@AyanSinhaMahapatra
Add required phrases for apache-1.1 rules
0da1c0b 
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
@AyanSinhaMahapatra
Update test expectaion
df5ddd7 
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
@AyanSinhaMahapatra AyanSinhaMahapatra changed the title Required phrase rules Add required phrase rules automatically Feb 17, 2023
@AyanSinhaMahapatra AyanSinhaMahapatra mentioned this pull request Mar 26, 2023
Open
@pombredanne pombredanne marked this pull request as draft April 24, 2023 15:45
@AyanSinhaMahapatra AyanSinhaMahapatra mentioned this pull request Aug 27, 2023
Closed
@AyanSinhaMahapatra AyanSinhaMahapatra mentioned this pull request Sep 15, 2023
Closed
@AyanSinhaMahapatra AyanSinhaMahapatra added this to the v32.1 milestone Jan 15, 2024
@AyanSinhaMahapatra
Merge branch 'develop' into required-phrase-rules
27f2d1c 
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
@AyanSinhaMahapatra
Move required-phrases script to licensedcode
9e49d80 
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
@AyanSinhaMahapatra
Add a new console script to add required phrases
9892ec2 
* moves the script to licensedcode
* adds a new console script `add-required-phrases`
* move the functions and tests to seperate files

Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
@AyanSinhaMahapatra
Update apache-2.0 rules with required phrases
109407a 
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
@AyanSinhaMahapatra AyanSinhaMahapatra marked this pull request as ready for review January 29, 2024 10:37
@AyanSinhaMahapatra AyanSinhaMahapatra modified the milestones: v32.1, v32.2 Feb 19, 2024
@pombredanne pombredanne mentioned this pull request Mar 20, 2024
Open
@pombredanne pombredanne mentioned this pull request Apr 12, 2024
Open
@AyanSinhaMahapatra AyanSinhaMahapatra mentioned this pull request Apr 26, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v32.2
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@AyanSinhaMahapatra