Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

componentWillMount, componentWillReceivePropsの警告を削除 #1

Merged
merged 3 commits into from
Oct 21, 2020

Conversation

yskoht
Copy link

@yskoht yskoht commented Sep 11, 2020

Fixes newn-team/standfm#4084

このPRではReactNativeアップグレード作業において、下記warningが出たのでこれを修正します。

Warning: componentWillReceiveProps has been renamed, and is not recommended for use. See https://fb.me/react-unsafe-component-lifecycles for details.

jeanregisser#170 をcherry-pickしました。
https://github.com/newn-team/standfm/pull/4329と合わせてレビューお願いします

参考:https://github.com/newn-team/standfm/issues/3941#issuecomment-690196039

@yskoht yskoht changed the base branch from master to standfm September 11, 2020 08:15
@yskoht yskoht changed the title [WIP]: componentWillMount, componentWillReceivePropsの警告を削除 [WIP] componentWillMount, componentWillReceivePropsの警告を削除 Sep 11, 2020
@yskoht yskoht changed the title [WIP] componentWillMount, componentWillReceivePropsの警告を削除 componentWillMount, componentWillReceivePropsの警告を削除 Sep 24, 2020
@yskoht yskoht self-assigned this Sep 24, 2020
@yskoht yskoht requested review from skahack and removed request for set0gut1 October 21, 2020 02:21
@yskoht
Copy link
Author

yskoht commented Oct 21, 2020

@skahack
すみません。こちらもレビュアー変えました。
よろしくお願いいたします。

Copy link

@skahack skahack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@skahack skahack merged commit 5406d4f into standfm Oct 21, 2020
@skahack skahack deleted the fix/3941 branch October 21, 2020 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants