Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BlueScreen HTTP Request: Add support for rendering PHP Input #392

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

BlueScreen HTTP Request: Add support for rendering PHP Input #392

wants to merge 2 commits into from

Conversation

janbarasek
Copy link
Contributor

  • new feature
  • BC break? yes

If request was called as ajax json payload with some data but without 'Content-Type': 'application/x-www-form-urlencoded' header, Tracy can not dump sent values.

This change add automatic detection of PHP Input and render to HTTP request section.

Example:

Snímek obrazovky 2019-11-01 v 12 12 52

If entered data was short json, Tracy will detect it automatically and dump as array for bette readability.

More information (Czech language): https://php.baraja.cz/ajax-post

Thanks.

@lukaspijak
Copy link

Hi it's nice feature but this "JSON detection" is very dumb. I think it would be better to detect JSON using content type (application/json).

@JanTvrdik
Copy link
Contributor

You cannot simple use file_get_contents('php://input'), because the output may be too large.

@janbarasek
Copy link
Contributor Author

Thanks to everybody.

@lukaspijak Added detection by HTTP header Content-Type which must starts with application/json. For example: application/json;charset=UTF-8

@JanTvrdik Added limitation for 10000 input characters.

@dg dg force-pushed the master branch 6 times, most recently from de3ad52 to 191c0d2 Compare December 15, 2019 22:49
@dg dg force-pushed the master branch 2 times, most recently from 2b958bb to f36b649 Compare January 2, 2020 19:40
@dg dg force-pushed the master branch 2 times, most recently from 68b0ec8 to 344c772 Compare February 23, 2020 18:40
@dg dg force-pushed the master branch 15 times, most recently from 8ec7417 to c8f135c Compare April 14, 2020 06:14
@KminekMatej
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants