Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix namespace sorting of capitalcase #120

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Conversation

Jeroeny
Copy link
Contributor

@Jeroeny Jeroeny commented Oct 13, 2022

  • bug fix
  • BC break? no

Before

use App\QueryCostSet;
use App\QueryCostsBootstrapped;

After

use App\QueryCostsBootstrapped;
use App\QueryCostSet;

@dg
Copy link
Member

dg commented Oct 13, 2022

I think that this is better:

use App\QueryCostP;
use App\QueryCostR;
use App\QueryCostT;
use App\QueryCostsBootstrapped;
use App\QueryCostsXyz;

than this:

use App\QueryCostP;
use App\QueryCostR;
use App\QueryCostsBootstrapped;
use App\QueryCostsXyz;
use App\QueryCostT;

@symfonyaml
Copy link

Hi @dg !
Do you think this PR will merged at some point ?
At the moment I hack the uasort(...) function by "strtolowering" the compared values in PhpNamespace.php

uasort(
    $this->aliases[$of],
    fn(string $a, string $b): int => strtr(strtolower($a), '\\', ' ') <=> strtr(strtolower($b), '\\', ' '),
);

@dg dg force-pushed the master branch 3 times, most recently from cb945ff to 08ab9bf Compare January 18, 2024 17:44
@dg dg force-pushed the master branch 2 times, most recently from e7c6dd5 to d961149 Compare February 12, 2024 11:26
@dg dg force-pushed the master branch 2 times, most recently from d243b95 to b135071 Compare March 7, 2024 23:07
@dg dg force-pushed the master branch 5 times, most recently from 22ab730 to 7a71f2f Compare May 16, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants