Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helper for parsing headers attributes #92

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Helper for parsing headers attributes #92

wants to merge 1 commit into from

Conversation

JanTvrdik
Copy link
Contributor

I'm missing a helper for parsing headers, i.e something that turns attachment; filename="example.php" into [filename => 'example.php']

@dg
Copy link
Member

dg commented May 1, 2016

Can you add it?

@fprochazka
Copy link
Contributor

fprochazka commented May 1, 2016 •
edited

@JanTvrdik Is there a standard for this? I haven't looked myself.

Shouldn't it be more something like [attachment => NULL, filename => 'example.php'] ?

@JanTvrdik
Copy link
Contributor Author

I'll, try to send PR today.

@Majkl578
Copy link
Contributor

Majkl578 commented May 1, 2016 •
edited

Is there a standard for this?

It depends afaik. There is standard for Accept headers as well as Content-Type header (RFC 7231) at least.

@JanTvrdik
Copy link
Contributor Author

JanTvrdik commented May 1, 2016 •
edited

It's not in one place, but if summarized, it leads to http://search.cpan.org/~ether/HTTP-Message-6.11/lib/HTTP/Headers/Util.pm

@JanTvrdik
Copy link
Contributor Author

JanTvrdik commented May 1, 2016 •
edited

Uf, as it turned out there is no unified standard (as pointed out for example here). So I guess we need to pick a list of headers which we actually want to be able to parse decide based on that.

The stuff is so fucked up that even browsers don't implement it correctly http://greenbytes.de/tech/tc/httpcontenttype/

Related links (so I don't have to look for them again)

@JanTvrdik JanTvrdik mentioned this pull request May 22, 2016
Merged
@dg dg force-pushed the master branch 2 times, most recently from 7981e33 to 3fb64f5 Compare July 21, 2016 12:07
@dg dg force-pushed the master branch 3 times, most recently from b9f06ea to 4f6d6c9 Compare December 20, 2016 14:30
@dg dg force-pushed the master branch 3 times, most recently from 2ff2f22 to 40175d7 Compare January 9, 2017 19:55
@dg dg force-pushed the master branch 12 times, most recently from 9c1fce0 to 96a1c05 Compare January 24, 2017 00:36
@dg dg force-pushed the master branch 2 times, most recently from 0f24022 to ebdb825 Compare January 15, 2023 17:08
@dg dg force-pushed the master branch 7 times, most recently from 684be2b to 2a0c595 Compare January 24, 2023 19:09
@dg dg force-pushed the master branch 6 times, most recently from da24b94 to 540335c Compare March 20, 2023 13:43
@dg dg force-pushed the master branch 2 times, most recently from e7c7e2d to bf945f3 Compare August 5, 2023 19:08
@dg dg force-pushed the master branch 3 times, most recently from 9a14e6e to a20fb8f Compare November 14, 2023 18:31
@dg dg force-pushed the master branch 5 times, most recently from 55488bd to 2042d2e Compare December 11, 2023 13:01
@dg dg force-pushed the master branch 2 times, most recently from 4960652 to 5e67add Compare May 2, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@JanTvrdik @dg @fprochazka @Majkl578 @f3l1x