FileUpload: fix getters calls on empty FileUpload #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dg
force-pushed
the
master
branch
4 times, most recently
from
6ee31b8
to
4f4a403
Compare
dg
force-pushed
the
master
branch
4 times, most recently
from
a8895b6
to
9409a5f
Compare
dg
force-pushed
the
master
branch
8 times, most recently
from
a85dc37
to
12e2e54
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
0f24022
to
ebdb825
Compare
dg
force-pushed
the
master
branch
7 times, most recently
from
684be2b
to
2a0c595
Compare
dg
force-pushed
the
master
branch
6 times, most recently
from
da24b94
to
540335c
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
e7c7e2d
to
bf945f3
Compare
dg
force-pushed
the
master
branch
3 times, most recently
from
9a14e6e
to
a20fb8f
Compare
dg
force-pushed
the
master
branch
5 times, most recently
from
55488bd
to
2042d2e
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
4960652
to
5e67add
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This happened to me recently: I forgot to mark form item with file upload as mandatory, so users were able to send form without any file. But on backend I have complex system of validators, which want to validate name, size etc. Validators are build using composition and each of them do just one thing (for example one of them just calls
getName(newlygetSanitizedName/getUntrustedName) on receivedFileUploadand checks its name...). It's not really handy to repeat in each of them condition with$file->isOk()... But if I didn't have it there, it would crash on the error:Return value of Nette\Http\FileUpload::getName() must be of the type string, null returned(in PHP 7.3), because properties don't have default values andnullis not compatible with typehintstring...I believe that getters should be callable without an error even on empty file upload, to make behavior of our
FileUploadmore predictable and consistent.I tried to add failing test and fix it.
I hope it's ok for you, just let me know if some changes needed.
Thanks.