Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mTLS client cert support for the PKCE idp provider #1905

Closed
wants to merge 14 commits into from

Conversation

Foosec
Copy link

@Foosec Foosec commented Apr 29, 2024

Describe your changes

Added configuration options to support working with an IDP provider that has mTLS enabled.
A working example is Authentik hosted behind a mTLS nginx reverse proxy, it adds security and helps mitigate 0-days on
.

I would appreciate the addition of this feature, and perhaps expanding on it to allow netbirds own APIs to be hosted
behind a mTLS proxy.

Not being familiar with the codebase, i hope i added it to the best location for this.

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • [x ] Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • Extended the README / documentation, if necessary

@CLAassistant
Copy link

CLAassistant commented Apr 29, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ Foosec
❌ foobar


foobar seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Foosec Foosec force-pushed the idp-mtls branch 4 times, most recently from 2187a3d to 50b220a Compare May 8, 2024 13:39
@Foosec Foosec closed this May 27, 2024
@Foosec Foosec deleted the idp-mtls branch May 27, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants