feat(typeorm): create initial support for typeorm ^0.3.0 and nest ^9.0.0 #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TypeORM has been upgraded to ^0.3.0. Nest has been upgraded to ^9.0.0. Minor changes to TypeORM crud service related to unique select columns. Major changes to tests to support new DataSource configuration. BREAKING CHANGE: TypeORM v0.3.0 came with many breaking changes, please see their release notes for more details. https://github.com/typeorm/typeorm/releases/tag/0.3.0 re nestjsx#790
fleetimee
approved these changes
Sep 7, 2022
fleetimee
approved these changes
Sep 11, 2022
BenStirrup
approved these changes
Oct 7, 2022
qstyler
approved these changes
Nov 2, 2022
| ...(isArrayFull(options.persist) ? options.persist : []), | ||
| ...columns, | ||
| ].map((col) => `${alias}.${col}`); | ||
| const select = new Set( |
michaelyali
approved these changes
Nov 29, 2022
|
@michaelyali any chance to release it soon? |
|
@theres yep |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypeORM has been upgraded to ^0.3.0. Nest has been upgraded to ^9.0.0. Minor changes to TypeORM crud
service related to unique select columns. Major changes to tests to support new DataSource
configuration.
BREAKING CHANGE: TypeORM v0.3.0 came with many breaking changes, please see their release notes for
more details. https://github.com/typeorm/typeorm/releases/tag/0.3.0
re #790
PR Checklist
Please check if your PR fulfills the following requirements:
yarn commitPR Type
What kind of change does this PR introduce?
What is the current behavior?
TypeORM ^0.3.0 is not supported.
Issue Number: 790
What is the new behavior?
TypeORM ^0.3.0 is supported, as well as Nest ^9.0.0 (required for latest TypeORM support)
Does this PR introduce a breaking change?
TypeORM ^0.3.0 introduced quite a few breaking changes, most significantly how connections are configured. See their release notes here: https://github.com/typeorm/typeorm/releases/tag/0.3.0
Nest ^9.0.0 is also required for the latest TypeORM ^0.3.0 support
Other information