Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dont omit signoptions in sign and signasync #1370

Closed
wants to merge 2 commits into from
Closed

fix: dont omit signoptions in sign and signasync #1370

wants to merge 2 commits into from

Conversation

aayushchugh
Copy link

@aayushchugh aayushchugh commented Jul 17, 2023 •
edited

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #1369
fixes #1369

What is the new behavior?

  1. Removed Omit type from sign and signAsync
  2. Failing tests are now passing
  3. Removed unused @ts-expect-error
  4. Allowed string type as parameter in sign and signAsync types

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

image

@kamilmysliwiec
Copy link
Member

cc @Hender-hs

tianangthang7
tianangthang7 approved these changes Sep 25, 2023
View reviewed changes
Copy link

@tianangthang7 tianangthang7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job

@kamilmysliwiec kamilmysliwiec mentioned this pull request Sep 26, 2023
Closed
4 tasks
@aayushchugh
Copy link
Author

@kamilmysliwiec Any update on this PR?

@aayushchugh
Copy link
Author

Closing this PR

@aayushchugh aayushchugh closed this Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamilmysliwiec kamilmysliwiec kamilmysliwiec left review comments

@tianangthang7 tianangthang7 tianangthang7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

type error while using expiresIn in signAsync
3 participants
@aayushchugh @kamilmysliwiec @tianangthang7