added in chicago elec dist #50
Conversation
| id: "chicagoelecdistus", | ||
| name: "Chicago Elec. Dist.", | ||
| country: :us, | ||
| homepage: "https://chicagodist.com/" |
There was a problem hiding this comment.
Can you remove the trailing /. (Damn this OCD all the time :D)
|
The parsing looks good. Two things:
Product that is on stock which has an items count: https://chicagodist.com/products/12-vdc-1000ma-regulated-switching-power-adapter-ul-listed |
|
| sku: "RPI4-MODBP-2GB" | ||
| }, | ||
| %ProductUpdate{ | ||
| url: "https://chicagodist.com/collections/raspberry-pi/products/raspberry-pi-4-model-b-1gb", |
There was a problem hiding this comment.
Lets change the url to https://chicagodist.com/products/raspberry-pi-4-model-b-1gb to be consistent with the other urls.
There was a problem hiding this comment.
Fixed! I put them in order too (to help with the OCD ha)
| Floki.find(html_tree, ".product_form") | ||
| |> Floki.attribute("data-variant-inventory") | ||
| |> Enum.at(0) | ||
| |> Jason.decode() | ||
|
|
||
| get_in(elem(json_product_data, 1) |> Enum.at(0), ["inventory_quantity"]) |
There was a problem hiding this comment.
You can change the code to this to reuse the existing variable and also simplify the last line where you get the value out of the json.
available_quantity
|> Enum.at(0)
|> Jason.decode!()
Enum.at(json_product_data, 0)["inventory_quantity"]
|
Looks good to me! Thanks! |
Added in Chicago Elec. Dist.