Move animation management out of Engine #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanvoljg
force-pushed
the
refactor/application-managed-animations
branch
from
dc998b1
to
d07dd37
Compare
added 5 commits
July 29, 2020 12:13
This moves responsibility for tracking animations and switching to next/previous animations out of the various paintables and into a single location
All animations have an initial render delay of 0ms for their initial frame.
vanvoljg
force-pushed
the
refactor/application-managed-animations
branch
from
d07dd37
to
7f5d16c
Compare
amclain
reviewed
Jul 30, 2020
added 2 commits
July 29, 2020 22:20
Completely removes config functions from Engine
Changes state into a struct and improves the config update function
amclain
reviewed
Jul 30, 2020
Allows instant access to a given index without modifying or traversing lists
|
wait, why was this closed, I haven't had a chance to look yet! |
|
I was able to have a chat with @vanvoljg offline. This PR was on track to merge and didn't have any blockers, so I think we can reopen it. |
amclain
approved these changes
Jul 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here, animation loading, state, and management are pulled out of
RGBMatrix.Engineand into theXebowapplication. This separates a few concerns to where theEngineonly has to deal with rendering,RGBMatrix.Animationhandles functions related to animations themselves, andXebowhandles creating the list of animations, initializing animations, switching animations, and persisting config modifications in memory.This should make it easier to introduce other application controlling logic such as animation activation/deactivation, configuration persistence between reboots, and eventually runtime discovery/installation of animations (which are currently hard-coded into the animation module).
This PR also fixes the black frame on live view creation, and removes the 0-ms
render_inthat was returned by all animations on callingnew/2. Animations which need to delay the render of their first frame could set the first frame to black, have an internal state that determines how long to wait, and check that state in itsrender/2callback functions.addresses part of #49, but leaves open a bunch of questions aboutruntime discovery of animations, enabling/disabling, etc.
closes #80
closes #83