Add test mode to eval CLI #2926
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kerrj
reviewed
Feb 20, 2024
| @@ -84,7 +84,7 @@ def __init__( | |||
| self, | |||
| config: FullImageDatamanagerConfig, | |||
| device: Union[torch.device, str] = "cpu", | |||
| test_mode: Literal["test", "val", "inference"] = "val", | |||
| test_mode: Literal["test", "val", "inference", "train"] = "val", | |||
There was a problem hiding this comment.
I think this should also be added in base_datamanager.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds test mode to
ns-evalCLI.With this, we can evaluate the model on custom split by specifying
test_mode.If this PR looks okay, I can add relevant docstrings and add this for all datamanagers.
Also, I have added
traintest mode, where the train data is loaded, in case people want to evaluate on thetrainset.Currently, this won't support custom files (not among train/test/val), but this would be nice to have that later.