Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove some magic numbers #168

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

YertleTurtleGit
Copy link
Contributor

No description provided.

@jb-ye
Copy link
Collaborator

jb-ye commented Apr 26, 2024

I intended to keep these magic numbers as they corresponds exactly to the reference code from the original authors, so people can verify the correctness/consistency of the implementation. But I think a better way here is instead of replacing these magic numbers, add some comments like:

result[..., 0] = 0.2820947917738781 #  SH_C0

What do you think?

@YertleTurtleGit
Copy link
Contributor Author

I intended to keep these magic numbers as they corresponds exactly to the reference code from the original authors, so people can verify the correctness/consistency of the implementation. But I think a better way here is instead of replacing these magic numbers, add some comments like:

result[..., 0] = 0.2820947917738781 #  SH_C0

What do you think?

Hey, thanks for the early comment. Didn't expect that (:
And regarding that: Makes sense. I'll handle that in the coming days if you don't mind.
Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants