Add support for batching by time params #1412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgeckhart
commented
May 13, 2024
Comment on lines
-60
to
-66
| type JobLevelMetricFields struct { | ||
| Statistics []string | ||
| Period int64 | ||
| Length int64 | ||
| Delay int64 | ||
| NilToZero *bool | ||
| AddCloudwatchTimestamp *bool |
There was a problem hiding this comment.
All of these fields are pushed down to the metric level and were no longer referenced
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the ability to batch the
GetMetricDatarequests by the params which directly influenceStartTimeandEndTimevs allowing them to vary per request batch. This is a backwards incompatible change which removes the usage of the config rounding period.Resolves #1290