Add AWS/EC2CapacityReservations to the services list #1341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cristiangreco would you mind reviewing this one? Not sure if I also need to include a test and/or update docs. Happy to do that if required |
|
I've tested against my sandbox AWS account and you get all the reservation
ids if I remember correctly. I can add that for completeness as it will be
optional
Let me run a couple of tests against my account and I will let you know
…On Wed, 10 Apr 2024, 16:21 Cristian Greco, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In pkg/config/services.go
<#1341 (comment)>
:
> @@ -334,6 +334,10 @@ var SupportedServices = serviceConfigs{
regexp.MustCompile("(?P<FleetRequestId>.*)"),
},
},
+ {
+ Namespace: "AWS/EC2CapacityReservations",
+ Alias: "ec2CapacityReservations",
I haven't tested this... do need to define a regexp here in order to
capture tagged resources?
—
Reply to this email directly, view it on GitHub
<#1341 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALTOHA7FSBRDVBXBYC5OPTY4VKI5AVCNFSM6AAAAABEZVCL5KVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSOJSGAZDKNRWG4>
.
You are receiving this because you authored the thread.Message ID:
<nerdswords/yet-another-cloudwatch-exporter/pull/1341/review/1992025667@
github.com>
|
|
@luismy any update on this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add
AWS/EC2CapacityReservationsto the services listContext
See issue #1324