-
-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for MediaPackage metrics #1046
base: master
Are you sure you want to change the base?
Conversation
Hi @theunissenne thanks for this contribution. What do you mean with the above? |
Well I checked if I could filter on dimension etc, but currently MediaPackage only has a few metricsEgressRequestCount etc. |
|
Yes, if resources in this namespace can be tagged, you should add a ResourceFilter and DimensionRegexps value for them. The former should be the namespace of the resources (guess it's
|
So, what exactly do you use these dimension for? |
I have been testing a bit, and it seems that MediaPackage has a dimension Channel, but we can't derive it from the arn. |
|
@theunissenne normally the regexps on the arn (e.g. What about other resources like |
Origin endpoints is the same case as mediapackage channels. and if you check the resourcearn: |
@theunissenne interesting, could you paste the complete output of the |
mediapackage_metrics.txt I think we either need to leave filtering blank, so that mediapackage-live metrics also appaer. |
Another option ofcourse is to somewhere in the code consider MediaPackage a special case, but this would polute the code right |
@theunissenne thanks for the files! The mediapackage namespace looks quite complex, with a lot of auto-generated ids in the dimensions. I've suggested an initial setup, could you please check it out? We can expand furter after some testing. |
Yeah sure. |
So I just tested a bit, but still there is something off if we just parse using IngestEndpoint. E.g. ` I'll verify it to be sure though |
@theunissenne sorry I lost momentum on this PR. Are you still interested in testing it and getting it merged? |
I tested it out and it seemed to work. However, our cloudwatch costs was immense due to using YACE (aws knows how to bill you for metrics). So we switch to the cloudwatch plugin. It can still be nice to merge it maybe for other users, otherwise it's not needed for my use case anymore :) |
As the metrics are currently very sparse, we can't use a resource or dimension filter yet.