Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade min python requirement to 3.8 #1794

Merged
merged 7 commits into from
May 28, 2024
Merged

Upgrade min python requirement to 3.8 #1794

merged 7 commits into from
May 28, 2024

Conversation

AleksanderWWW
Copy link
Contributor

@AleksanderWWW AleksanderWWW commented May 23, 2024

Before submitting checklist

  • Did you update the CHANGELOG? (not for test updates, internal changes/refactors or CI/CD setup)
  • Did you ask the docs owner to review all the user-facing changes?

Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.30%. Comparing base (0c43a0f) to head (bbefca8).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1794      +/-   ##
==========================================
- Coverage   79.58%   73.30%   -6.29%     
==========================================
  Files         372      258     -114     
  Lines       20289    13611    -6678     
==========================================
- Hits        16148     9978    -6170     
+ Misses       4141     3633     -508     
Flag Coverage Δ
e2e ?
e2e-management ?
e2e-s3 ?
e2e-s3-gcs ?
e2e-standard ?
macos 73.22% <100.00%> (-6.15%) ⬇️
py3.10 ?
py3.11 ?
py3.12 ?
py3.7 ?
py3.8 73.30% <100.00%> (-6.18%) ⬇️
py3.9 ?
ubuntu 73.22% <100.00%> (-6.19%) ⬇️
unit 73.30% <100.00%> (-2.26%) ⬇️
windows 72.09% <100.00%> (-6.47%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pyproject.toml Outdated
@@ -30,14 +29,15 @@ websocket-client = ">=0.35.0, !=1.0.0"
urllib3 = "*"
swagger-spec-validator = ">=2.7.4"
protobuf = "^4.0.0"
grpcio = ">=1.0.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use ^1.0.0

@AleksanderWWW AleksanderWWW merged commit a00581e into master May 28, 2024
4 checks passed
@AleksanderWWW AleksanderWWW deleted the aw/python-3.8 branch May 28, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants