Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

neptune.internal.hardware removed #1783

Merged
merged 1 commit into from
May 27, 2024
Merged

Conversation

Raalsky
Copy link
Contributor

@Raalsky Raalsky commented May 20, 2024

Before submitting checklist

  • Did you update the CHANGELOG? (not for test updates, internal changes/refactors or CI/CD setup)
  • Did you ask the docs owner to review all the user-facing changes?

Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.97%. Comparing base (4716f23) to head (27f133d).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1783      +/-   ##
==========================================
- Coverage   79.52%   70.97%   -8.56%     
==========================================
  Files         371      236     -135     
  Lines       20270    13149    -7121     
==========================================
- Hits        16120     9332    -6788     
+ Misses       4150     3817     -333     
Flag Coverage Δ
e2e ?
e2e-management ?
e2e-s3 ?
e2e-s3-gcs ?
e2e-standard ?
macos 70.74% <100.00%> (-8.55%) ⬇️
py3.10 ?
py3.11 ?
py3.12 ?
py3.7 70.25% <100.00%> (-8.58%) ⬇️
py3.8 70.74% <100.00%> (-8.67%) ⬇️
py3.9 ?
ubuntu 70.16% <100.00%> (-9.19%) ⬇️
unit 70.97% <100.00%> (-4.52%) ⬇️
windows 68.98% <100.00%> (-9.55%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Raalsky Raalsky merged commit 1f4f371 into master May 27, 2024
4 checks passed
@Raalsky Raalsky deleted the rj/hardware-monitoring-removed branch May 27, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants