Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(completion): add new highlight PmenuMatch #28581

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

glepnir
Copy link
Member

@glepnir glepnir commented Apr 30, 2024

Problem: missing highlight for matched leader text within candidate words.

Solutin: add highlight for the text pos which matched leader in candidate words.

Fix #8780

draft as 0.11

Problem: missing highlight for matched leader text within candidate words.

Solutin: add highlight for the text pos which matched leader in candidate words.
@glepnir glepnir marked this pull request as draft April 30, 2024 13:04
@github-actions github-actions bot added the completion Nvim built-in (omni)completion label Apr 30, 2024
@clason
Copy link
Member

clason commented Apr 30, 2024

Such changes should go through Vim first, if possible.

@glepnir
Copy link
Member Author

glepnir commented Apr 30, 2024

yes. but vim doesn't have grid. but i will try to port it, so just keep it as a draft for now 😸

@clason
Copy link
Member

clason commented Apr 30, 2024

It's about the interface and documentation more than about the implementation.

@zeertzjq zeertzjq added this to the 0.11 milestone Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completion Nvim built-in (omni)completion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new highlight group for Pmenu text-typed-so-far
3 participants